You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Olivier Lamy <ol...@accor.com> on 2005/11/29 19:44:57 UTC

RE : RE : War phases, binding a custom plugin to the war creation

If all users interested by improving push a vote to this issue :
http://jira.codehaus.org/browse/MNG-1683
Someone will probably listen this call  ;-)
Maybe it's not the best way to do and can be improved.

A previous post on this list said : 
"If some of you want to help us you're welcome !!!
Send us patchs, we'll appreciate it a lot."

Some people do it but no feedback from the developpers.

Sorry if this mail doesn't sounds good (it's not the goal but the only
the preGoal ;-)), but some users try to be more than simple lurkers !.

Then if you want more people use this wonderful maven2 (yes it's great
and congratulations again for all jobs), listen them a little bit ...
 
- Olivier

PS : I have a workaround : made my own hack and not shared it (but I
don't know if it's the good way ..)


-----Message d'origine-----
De : Kevin Galligan [mailto:mailinglits@kgalligan.com] 
Envoyé : mardi 29 novembre 2005 19:15
À : Maven Users List
Objet : Re: RE : War phases, binding a custom plugin to the war creation


I've hacked up the maven-war-plugin to merge war dependencies into the 
final product.  I posted the code originally, but I've added a few 
things since then.  These include an updated version of the cargo 
web.xml merging code.  The current version only merges certain parts of 
the web.xml.  Internally we needed more.

I also track the war file version to we don't need a full extract of 
dependent wars every time a build is done.  The way I do this is very 
hacky, but functional.

Anyway, wondering if anybody would be interested, and/or if this kind of

functionality would be considered for a future add.

Olivier Lamy wrote:
> Hi,
> I'm happy to see that some users needs more feature in the 
> maven-war-plugin !! It works but for simple webapp and you need to add

> some embedeed ant scripts in order to copy some files (it's really 
> clean). I have provided a patch 
> http://jira.codehaus.org/browse/MNG-1683 which add some features.
> Take this
>
http://jira.codehaus.org/secure/attachment/17799/maven-war-plugin.tar.gz
> 
> - Unzip it
> - install the plugin : mvn -DupdateReleaseInfo=true clean install
> - look at the documentation : mvn site
> 
> Exemple :
> To add jsp files add this in the configuration :
> 		<webappDirectory 
> implementation="java.io.File">${basedir}/webappdir</webappDirectory>
>           <resources>
>             <resource>
>               <directory>${basedir}/src/main/jsp</directory>
> 
>               <targetPath>${basedir}/webappdir</targetPath>
> 		  <!-- note ${webappDirectory} doesn't work due to some 
> introspection trouble
> 			I have updated my local version to copy
> resources to a target path relative to ${webappDirectory}
> 		 -->
>             </resource>
>           
>           </resources>
> 
> I don't really know if this kind of features will be added one day in 
> the maven-war-plugin.... (because in some contexts create a war is 
> more complicated than the jobs provided by the default plugin)
> 
> Note the issue http://jira.codehaus.org/browse/MNG-791 (mark as fixed 
> in 2.0.1).
> 
> HTH,
> 
> - Olivier
> 
> -----Message d'origine-----
> De : Bruno Aranda [mailto:brunoaranda@gmail.com]
> Envoyé : mardi 29 novembre 2005 18:46
> À : Maven Users List
> Objet : War phases, binding a custom plugin to the war creation
> 
> 
> Hi all,
> 
> I would like to know what phase I have to use to bind a plugin to the 
> war creation (war:war).
> 
>  <plugin>
>      <groupId>my.groupId</groupId>
>      <artifactId>maven-myPlugin-plugin</artifactId>
>      <executions>
>        <execution>
>          <phase>WHAT TO PUT HERE</phase>
>          <goals>
>            <goal>myPluginGoal</goal>
>          </goals>
>        </execution>
>      </executions>
>    </plugin>
> 
> It works ok for the process-resources and package phases, but the 
> first is too early, and the other is too late. I am trying to copy 
> some JSP pages in a specific way to the exploded war folder before 
> creating the war file,
> 
> TIA,
> 
> Bruno
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
> 
> 
> 
> This e-mail, any attachments and the information contained therein 
> ("this message") are confidential and intended solely for the use of
the addressee(s). If you have received this message in error please send
it back to the sender and delete it. Unauthorized publication, use,
dissemination or disclosure of this message, either in whole or in part
is strictly prohibited.
> **********************************************************************

> Ce message électronique et tous les fichiers joints ainsi que  les
informations contenues dans ce message ( ci après "le message" ), sont
confidentiels et destinés exclusivement à l'usage de la  personne à
laquelle ils sont adressés. Si vous avez reçu ce message par erreur,
merci  de le renvoyer à son émetteur et de le détruire. Toutes
diffusion, publication, totale ou partielle ou divulgation sous quelque
forme que se soit non expressément autorisées de ce message, sont
interdites.
> **********************************************************************

> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


RE : RE : RE : War phases, binding a custom plugin to the war creation

Posted by Olivier Lamy <ol...@accor.com>.
Ok no problem and thanks in advance.

- Olivier

-----Message d'origine-----
De : Brett Porter [mailto:brett.porter@gmail.com] 
Envoyé : mardi 29 novembre 2005 21:40
À : Maven Users List
Objet : Re: RE : RE : War phases, binding a custom plugin to the war
creation


Olivier,

What makes you think the developers aren't listening? The issue was
filed less than a week ago, so it will get looked at - but it isn't
always immediate. Voting and comments from other people on the patch
are definitely very helpful, and we always appreciate people taking
the time to make contributions.

Cheers,
Brett

On 11/30/05, Olivier Lamy <ol...@accor.com> wrote:
> If all users interested by improving push a vote to this issue :
> http://jira.codehaus.org/browse/MNG-1683
> Someone will probably listen this call  ;-)
> Maybe it's not the best way to do and can be improved.
>
> A previous post on this list said :
> "If some of you want to help us you're welcome !!!
> Send us patchs, we'll appreciate it a lot."
>
> Some people do it but no feedback from the developpers.
>
> Sorry if this mail doesn't sounds good (it's not the goal but the only
> the preGoal ;-)), but some users try to be more than simple lurkers !.
>
> Then if you want more people use this wonderful maven2 (yes it's great
> and congratulations again for all jobs), listen them a little bit ...
>
> - Olivier
>
> PS : I have a workaround : made my own hack and not shared it (but I
> don't know if it's the good way ..)
>
>
> -----Message d'origine-----
> De : Kevin Galligan [mailto:mailinglits@kgalligan.com]
> Envoyé : mardi 29 novembre 2005 19:15
> À : Maven Users List
> Objet : Re: RE : War phases, binding a custom plugin to the war
creation
>
>
> I've hacked up the maven-war-plugin to merge war dependencies into the
> final product.  I posted the code originally, but I've added a few
> things since then.  These include an updated version of the cargo
> web.xml merging code.  The current version only merges certain parts
of
> the web.xml.  Internally we needed more.
>
> I also track the war file version to we don't need a full extract of
> dependent wars every time a build is done.  The way I do this is very
> hacky, but functional.
>
> Anyway, wondering if anybody would be interested, and/or if this kind
of
>
> functionality would be considered for a future add.
>
> Olivier Lamy wrote:
> > Hi,
> > I'm happy to see that some users needs more feature in the
> > maven-war-plugin !! It works but for simple webapp and you need to
add
>
> > some embedeed ant scripts in order to copy some files (it's really
> > clean). I have provided a patch
> > http://jira.codehaus.org/browse/MNG-1683 which add some features.
> > Take this
> >
>
http://jira.codehaus.org/secure/attachment/17799/maven-war-plugin.tar.gz
> >
> > - Unzip it
> > - install the plugin : mvn -DupdateReleaseInfo=true clean install
> > - look at the documentation : mvn site
> >
> > Exemple :
> > To add jsp files add this in the configuration :
> >               <webappDirectory
> > implementation="java.io.File">${basedir}/webappdir</webappDirectory>
> >           <resources>
> >             <resource>
> >               <directory>${basedir}/src/main/jsp</directory>
> >
> >               <targetPath>${basedir}/webappdir</targetPath>
> >                 <!-- note ${webappDirectory} doesn't work due to
some
> > introspection trouble
> >                       I have updated my local version to copy
> > resources to a target path relative to ${webappDirectory}
> >                -->
> >             </resource>
> >
> >           </resources>
> >
> > I don't really know if this kind of features will be added one day
in
> > the maven-war-plugin.... (because in some contexts create a war is
> > more complicated than the jobs provided by the default plugin)
> >
> > Note the issue http://jira.codehaus.org/browse/MNG-791 (mark as
fixed
> > in 2.0.1).
> >
> > HTH,
> >
> > - Olivier
> >
> > -----Message d'origine-----
> > De : Bruno Aranda [mailto:brunoaranda@gmail.com]
> > Envoyé : mardi 29 novembre 2005 18:46
> > À : Maven Users List
> > Objet : War phases, binding a custom plugin to the war creation
> >
> >
> > Hi all,
> >
> > I would like to know what phase I have to use to bind a plugin to
the
> > war creation (war:war).
> >
> >  <plugin>
> >      <groupId>my.groupId</groupId>
> >      <artifactId>maven-myPlugin-plugin</artifactId>
> >      <executions>
> >        <execution>
> >          <phase>WHAT TO PUT HERE</phase>
> >          <goals>
> >            <goal>myPluginGoal</goal>
> >          </goals>
> >        </execution>
> >      </executions>
> >    </plugin>
> >
> > It works ok for the process-resources and package phases, but the
> > first is too early, and the other is too late. I am trying to copy
> > some JSP pages in a specific way to the exploded war folder before
> > creating the war file,
> >
> > TIA,
> >
> > Bruno
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
> >
> > This e-mail, any attachments and the information contained therein
> > ("this message") are confidential and intended solely for the use of
> the addressee(s). If you have received this message in error please
send
> it back to the sender and delete it. Unauthorized publication, use,
> dissemination or disclosure of this message, either in whole or in
part
> is strictly prohibited.
> >
**********************************************************************
>
> > Ce message électronique et tous les fichiers joints ainsi que  les
> informations contenues dans ce message ( ci après "le message" ), sont
> confidentiels et destinés exclusivement à l'usage de la  personne à
> laquelle ils sont adressés. Si vous avez reçu ce message par erreur,
> merci  de le renvoyer à son émetteur et de le détruire. Toutes
> diffusion, publication, totale ou partielle ou divulgation sous
quelque
> forme que se soit non expressément autorisées de ce message, sont
> interdites.
> >
**********************************************************************
>
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: RE : RE : War phases, binding a custom plugin to the war creation

Posted by Brett Porter <br...@gmail.com>.
Olivier,

What makes you think the developers aren't listening? The issue was
filed less than a week ago, so it will get looked at - but it isn't
always immediate. Voting and comments from other people on the patch
are definitely very helpful, and we always appreciate people taking
the time to make contributions.

Cheers,
Brett

On 11/30/05, Olivier Lamy <ol...@accor.com> wrote:
> If all users interested by improving push a vote to this issue :
> http://jira.codehaus.org/browse/MNG-1683
> Someone will probably listen this call  ;-)
> Maybe it's not the best way to do and can be improved.
>
> A previous post on this list said :
> "If some of you want to help us you're welcome !!!
> Send us patchs, we'll appreciate it a lot."
>
> Some people do it but no feedback from the developpers.
>
> Sorry if this mail doesn't sounds good (it's not the goal but the only
> the preGoal ;-)), but some users try to be more than simple lurkers !.
>
> Then if you want more people use this wonderful maven2 (yes it's great
> and congratulations again for all jobs), listen them a little bit ...
>
> - Olivier
>
> PS : I have a workaround : made my own hack and not shared it (but I
> don't know if it's the good way ..)
>
>
> -----Message d'origine-----
> De : Kevin Galligan [mailto:mailinglits@kgalligan.com]
> Envoyé : mardi 29 novembre 2005 19:15
> À : Maven Users List
> Objet : Re: RE : War phases, binding a custom plugin to the war creation
>
>
> I've hacked up the maven-war-plugin to merge war dependencies into the
> final product.  I posted the code originally, but I've added a few
> things since then.  These include an updated version of the cargo
> web.xml merging code.  The current version only merges certain parts of
> the web.xml.  Internally we needed more.
>
> I also track the war file version to we don't need a full extract of
> dependent wars every time a build is done.  The way I do this is very
> hacky, but functional.
>
> Anyway, wondering if anybody would be interested, and/or if this kind of
>
> functionality would be considered for a future add.
>
> Olivier Lamy wrote:
> > Hi,
> > I'm happy to see that some users needs more feature in the
> > maven-war-plugin !! It works but for simple webapp and you need to add
>
> > some embedeed ant scripts in order to copy some files (it's really
> > clean). I have provided a patch
> > http://jira.codehaus.org/browse/MNG-1683 which add some features.
> > Take this
> >
> http://jira.codehaus.org/secure/attachment/17799/maven-war-plugin.tar.gz
> >
> > - Unzip it
> > - install the plugin : mvn -DupdateReleaseInfo=true clean install
> > - look at the documentation : mvn site
> >
> > Exemple :
> > To add jsp files add this in the configuration :
> >               <webappDirectory
> > implementation="java.io.File">${basedir}/webappdir</webappDirectory>
> >           <resources>
> >             <resource>
> >               <directory>${basedir}/src/main/jsp</directory>
> >
> >               <targetPath>${basedir}/webappdir</targetPath>
> >                 <!-- note ${webappDirectory} doesn't work due to some
> > introspection trouble
> >                       I have updated my local version to copy
> > resources to a target path relative to ${webappDirectory}
> >                -->
> >             </resource>
> >
> >           </resources>
> >
> > I don't really know if this kind of features will be added one day in
> > the maven-war-plugin.... (because in some contexts create a war is
> > more complicated than the jobs provided by the default plugin)
> >
> > Note the issue http://jira.codehaus.org/browse/MNG-791 (mark as fixed
> > in 2.0.1).
> >
> > HTH,
> >
> > - Olivier
> >
> > -----Message d'origine-----
> > De : Bruno Aranda [mailto:brunoaranda@gmail.com]
> > Envoyé : mardi 29 novembre 2005 18:46
> > À : Maven Users List
> > Objet : War phases, binding a custom plugin to the war creation
> >
> >
> > Hi all,
> >
> > I would like to know what phase I have to use to bind a plugin to the
> > war creation (war:war).
> >
> >  <plugin>
> >      <groupId>my.groupId</groupId>
> >      <artifactId>maven-myPlugin-plugin</artifactId>
> >      <executions>
> >        <execution>
> >          <phase>WHAT TO PUT HERE</phase>
> >          <goals>
> >            <goal>myPluginGoal</goal>
> >          </goals>
> >        </execution>
> >      </executions>
> >    </plugin>
> >
> > It works ok for the process-resources and package phases, but the
> > first is too early, and the other is too late. I am trying to copy
> > some JSP pages in a specific way to the exploded war folder before
> > creating the war file,
> >
> > TIA,
> >
> > Bruno
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
> >
> > This e-mail, any attachments and the information contained therein
> > ("this message") are confidential and intended solely for the use of
> the addressee(s). If you have received this message in error please send
> it back to the sender and delete it. Unauthorized publication, use,
> dissemination or disclosure of this message, either in whole or in part
> is strictly prohibited.
> > **********************************************************************
>
> > Ce message électronique et tous les fichiers joints ainsi que  les
> informations contenues dans ce message ( ci après "le message" ), sont
> confidentiels et destinés exclusivement à l'usage de la  personne à
> laquelle ils sont adressés. Si vous avez reçu ce message par erreur,
> merci  de le renvoyer à son émetteur et de le détruire. Toutes
> diffusion, publication, totale ou partielle ou divulgation sous quelque
> forme que se soit non expressément autorisées de ce message, sont
> interdites.
> > **********************************************************************
>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org