[GitHub] [hbase] shahrs87 commented on a change in pull request #2707: [HBASE-25328] Add builder method to create Tags.

[GitBox <gi...@apache.org>]

shahrs87 commented on a change in pull request #2707:
URL: https://github.com/apache/hbase/pull/2707#discussion_r537131322



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferTag.java
##########
@@ -44,6 +44,21 @@ public ByteBufferTag(ByteBuffer buffer, int offset, int length) {
     this.type = ByteBufferUtils.toByte(buffer, offset + TAG_LENGTH_SIZE);
   }
 
+  /**
+   * This constructor <b>just contains the tag value</b> in ByteBuffer. In above constructor,
+   * tag length and tag type are also contained in the ByteBuffer.
+   * @param buffer input byte buffer
+   * @param type  type of the tag
+   * @param offset offset of the start of tag in byte buffer
+   * @param length length of the tag
+   */
+  public ByteBufferTag(ByteBuffer buffer, byte type, int offset, int length) {

Review comment:
       Thank you for the review. Addressed it in latest commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org