You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2016/07/30 11:49:55 UTC
Merging github pull requests
Does anyone have experience merging Github pull requests into Log4j2?
The pull requests are based on the github.com mirror of the git.apache.org
repository so a lot of the instructions don't make sense to me.
I want to work on https://github.com/apache/logging-log4j2/pull/34 but
don't know how to make progress. I would be okay with creating a patch and
merging that but I cannot fin a way to do this from the github.com web
interface.
Remko
Re: Merging github pull requests
Posted by Remko Popma <re...@gmail.com>.
Thanks guys!
Sent from my iPhone
> On 2016/07/31, at 2:01, Matt Sicker <bo...@gmail.com> wrote:
>
> On the initial pull request, the sent email has the git commands to pull it Ito your own git repo. You can also just turn it into a patch file like Gary mentioned, too.
>
> On Saturday, 30 July 2016, Gary Gregory <ga...@gmail.com> wrote:
>> Try adding ".patch" or ".diff" to the github URL
>>
>>
>>> On Jul 30, 2016 4:50 AM, "Remko Popma" <re...@gmail.com> wrote:
>>> Does anyone have experience merging Github pull requests into Log4j2?
>>> The pull requests are based on the github.com mirror of the git.apache.org repository so a lot of the instructions don't make sense to me.
>>>
>>> I want to work on https://github.com/apache/logging-log4j2/pull/34 but don't know how to make progress. I would be okay with creating a patch and merging that but I cannot fin a way to do this from the github.com web interface.
>>>
>>> Remko
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: Merging github pull requests
Posted by Matt Sicker <bo...@gmail.com>.
On the initial pull request, the sent email has the git commands to pull it
Ito your own git repo. You can also just turn it into a patch file like
Gary mentioned, too.
On Saturday, 30 July 2016, Gary Gregory <ga...@gmail.com> wrote:
> Try adding ".patch" or ".diff" to the github URL
>
> On Jul 30, 2016 4:50 AM, "Remko Popma" <remko.popma@gmail.com
> <javascript:_e(%7B%7D,'cvml','remko.popma@gmail.com');>> wrote:
>
>> Does anyone have experience merging Github pull requests into Log4j2?
>> The pull requests are based on the github.com mirror of the
>> git.apache.org repository so a lot of the instructions don't make sense
>> to me.
>>
>> I want to work on https://github.com/apache/logging-log4j2/pull/34 but
>> don't know how to make progress. I would be okay with creating a patch and
>> merging that but I cannot fin a way to do this from the github.com web
>> interface.
>>
>> Remko
>>
>
--
Matt Sicker <bo...@gmail.com>
Re: Merging github pull requests
Posted by Gary Gregory <ga...@gmail.com>.
Try adding ".patch" or ".diff" to the github URL
On Jul 30, 2016 4:50 AM, "Remko Popma" <re...@gmail.com> wrote:
> Does anyone have experience merging Github pull requests into Log4j2?
> The pull requests are based on the github.com mirror of the git.apache.org
> repository so a lot of the instructions don't make sense to me.
>
> I want to work on https://github.com/apache/logging-log4j2/pull/34 but
> don't know how to make progress. I would be okay with creating a patch and
> merging that but I cannot fin a way to do this from the github.com web
> interface.
>
> Remko
>