[GitHub] [spark] cloud-fan commented on a diff in pull request #42185: [SPARK-44287][SQL][FOLLOWUP] Set partition index correctly

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42185:
URL: https://github.com/apache/spark/pull/42185#discussion_r1275903701


##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -279,40 +279,36 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper {
     }
     withSession(extensions) { session =>
       session.conf.set(SQLConf.ADAPTIVE_EXECUTION_ENABLED, enableAQE)
-      Seq(true, false).foreach { enableEvaluator =>

Review Comment:
   According to the previous discussion, we don't need to test it as we are already using the evaluator by default, and we can test `RDD#mapPartitionsWithEvaluator` when we use it by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org