You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/19 06:28:00 UTC
[jira] [Commented] (FLINK-7224) Incorrect Javadoc description in
all Kafka consumer versions
[ https://issues.apache.org/jira/browse/FLINK-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092654#comment-16092654 ]
ASF GitHub Bot commented on FLINK-7224:
---------------------------------------
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/4363
[FLINK-7224] [kafka, docs] Fix incorrect Javadoc / docs regarding Kafka partition metadata querying
Since Flink 1.3, partition metadata is no longer queried on the client
side. This commit corrects the statements of this legacy behaviour in
the Javadocs and documentation.
This should be merged for both `release-1.3` and `master`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-7224
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4363
----
commit 8341083005e4de64b5d1b4e1fe2a543975197d02
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-07-19T06:24:27Z
[FLINK-7224] [kafka, docs] Fix incorrect Javadoc / docs regarding Kafka partition metadata querying
Since Flink 1.3, partition metadata is no longer queried on the client
side. This commit corrects the statements of this legacy behaviour in
the Javadocs and documentation.
----
> Incorrect Javadoc description in all Kafka consumer versions
> ------------------------------------------------------------
>
> Key: FLINK-7224
> URL: https://issues.apache.org/jira/browse/FLINK-7224
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Affects Versions: 1.3.1, 1.4.0
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
>
> Currently, all Kafka consumer version still have this in the Javadoc:
> {code}
> The implementation currently accesses partition metadata when the consumer
> is constructed. That means that the client that submits the program needs to be able to
> reach the Kafka brokers or ZooKeeper.
> {code}
> This is also the case for the documentation:
> {code}
> The current FlinkKafkaConsumer implementation will establish a connection from the client (when calling the constructor) for querying the list of topics and partitions.
> For this to work, the consumer needs to be able to access the consumers from the machine submitting the job to the Flink cluster. If you experience any issues with the Kafka consumer on the client side, the client log might contain information about failed requests, etc.
> {code}
> These statements are no longer true since starting from Flink 1.3. partition metadata happens only in {{open()}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)