[DISCUSS/PROPOSAL] More Karaf services usage

[Jean-Baptiste Onofré <jb...@nanthrax.net>]

Hi all,

I'm working on the addition of a set of new Karaf MBeans.

The purpose of these MBeans is to give the same actions that can be 
performed with the shell commands.

Regarding this, I saw that a lot of logics are implemented in the 
commands itself, shipping some util classes.

It means that the code is not really re-usable, and the only workaround 
is code duplication.

For Karaf 3.0 (or 3.1), I propose to refactore a maximum of things to 
use services. The logic is implemented in the service, and, for 
instance, shell commands and MBeans could use this service.
More over, it means that we can completely change the implementation 
without updating the commands or MBeans.

WDYT ?

Regards
JB
-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: [DISCUSS/PROPOSAL] More Karaf services usage

[Christian Schneider <ch...@die-schneider.net>]

Sounds good.

Christian


Am 23.09.2011 21:52, schrieb Jean-Baptiste Onofré:
> Hi all,
>
> I'm working on the addition of a set of new Karaf MBeans.
>
> The purpose of these MBeans is to give the same actions that can be 
> performed with the shell commands.
>
> Regarding this, I saw that a lot of logics are implemented in the 
> commands itself, shipping some util classes.
>
> It means that the code is not really re-usable, and the only 
> workaround is code duplication.
>
> For Karaf 3.0 (or 3.1), I propose to refactore a maximum of things to 
> use services. The logic is implemented in the service, and, for 
> instance, shell commands and MBeans could use this service.
> More over, it means that we can completely change the implementation 
> without updating the commands or MBeans.
>
> WDYT ?
>
> Regards
> JB

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

Re: [DISCUSS/PROPOSAL] More Karaf services usage

[Achim Nierbeck <bc...@googlemail.com>]

yeah, I'm a fan of DRY so I just can repeat Jamie and Ioannis,
kind of ironic here ;)

regards, Achim

Am 24.09.2011 17:34, schrieb Jamie G.:
> Same comment as Ioannis, less duplication of code is desirable.
>
> Cheers,
> Jamie
>
> On Fri, Sep 23, 2011 at 5:33 PM, Ioannis Canellos <io...@gmail.com> wrote:
>> Since, we don't want to have duplicate code, I think that in general it
>> sounds good.
>> --
>> *Ioannis Canellos*
>> *
>> FuseSource <http://fusesource.com>
>>
>> **
>> Blog: http://iocanel.blogspot.com
>> **
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> Apache ServiceMix <http://servicemix.apache.org/>  Committer
>> Apache Gora <http://incubator.apache.org/gora/> Committer
>> *
>>


-- 
-----

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>  Committer & Project Lead

Re: [DISCUSS/PROPOSAL] More Karaf services usage

["Jamie G." <ja...@gmail.com>]

Same comment as Ioannis, less duplication of code is desirable.

Cheers,
Jamie

On Fri, Sep 23, 2011 at 5:33 PM, Ioannis Canellos <io...@gmail.com> wrote:
> Since, we don't want to have duplicate code, I think that in general it
> sounds good.
> --
> *Ioannis Canellos*
> *
> FuseSource <http://fusesource.com>
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> Apache ServiceMix <http://servicemix.apache.org/>  Committer
> Apache Gora <http://incubator.apache.org/gora/> Committer
> *
>

Re: [DISCUSS/PROPOSAL] More Karaf services usage

[Ioannis Canellos <io...@gmail.com>]

Since, we don't want to have duplicate code, I think that in general it
sounds good.
-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Apache Karaf <http://karaf.apache.org/> Committer & PMC
Apache ServiceMix <http://servicemix.apache.org/>  Committer
Apache Gora <http://incubator.apache.org/gora/> Committer
*