You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2017/05/17 22:32:30 UTC

[GitHub] incubator-madlib pull request #136: Graph: Add APSP with grouping

GitHub user orhankislal opened a pull request:

    https://github.com/apache/incubator-madlib/pull/136

    Graph: Add APSP with grouping

    JIRA: MADLIB-1099
    
    - Add all pairs shortest path algorithm with grouping support.
    This algorithm provides the minimum cost (sum of edge weights) paths for
    every vertex pair in the graph.
    - Add the get path algorithm to find the actual path for any vertex pair
    (with grouping support)
    - Minor changes in SSSP and graph utilities.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/orhankislal/incubator-madlib graph/apsp_gr_take2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit b6ce2c8deead3502051d215b937836e19451f8a6
Author: Orhan Kislal <ok...@pivotal.io>
Date:   2017-05-17T22:29:30Z

    Graph: Add APSP with grouping
    
    JIRA: MADLIB-1099
    
    - Add all pairs shortest path algorithm with grouping support.
    This algorithm provides the minimum cost (sum of edge weights) paths for
    every vertex pair in the graph.
    - Add the get path algorithm to find the actual path for any vertex pair
    (with grouping support)
    - Minor changes in SSSP and graph utilities.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #136: Graph: Add APSP with grouping

Posted by rashmi815 <gi...@git.apache.org>.
Github user rashmi815 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/136
  
    Re-ran the test with the latest commit and it works fine now. Thanks @orhankislal . 
    ```sql
    drop table if exists out_disc, out_disc_summary;
    SELECT madlib.graph_apsp('vertex_disc',NULL,'edge_disc',NULL,'out_disc');
     graph_apsp 
    ------------
     
    (1 row)
    
    drop table if exists out_disc_path;
    select madlib.graph_apsp_get_path('out_disc',1,5,'out_disc_path');
     graph_apsp_get_path 
    ---------------------
     
    (1 row)
    
    
    select * from out_disc_path;
      path   
    ---------
     {1,3,5}
    (1 row)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #136: Graph: Add APSP with grouping

Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:

    https://github.com/apache/incubator-madlib/pull/136
  
    @raghur1 I was trying to avoid the distinct on clause to speed up the implementation but you are right to point this out, this output is not correct. Should be fixed with my latest commit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #136: Graph: Add APSP with grouping

Posted by rashmi815 <gi...@git.apache.org>.
Github user rashmi815 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/136
  
    Ran a test with the following data set and found that the get_path function outputs two paths for the example I tried (tests were run using a Greenplum database 4.3.12 VM on local machine).  See below:
    ```sql
    drop table if exists vertex_disc, edge_disc;
    
    create table vertex_disc (id integer) distributed by (id);
    create table edge_disc (src int, dest int, weight float8) distributed randomly;
    
    insert into vertex_disc VALUES
    (0),
    (1),
    (2),
    (3),
    (4),
    (5),
    (6),
    (7),
    (8),
    (9),
    (10)
    ;
    
    insert into edge_disc VALUES
    (0, 5, 1),
    (1, 0, 1),
    (1, 3, 1),
    (2, 6, 1),
    (3, 4, 1),
    (3, 5, 1),
    (4, 2, 1),
    (8, 9, 1),
    (10, 8, 1)
    ;
    
    drop table if exists out_disc, out_disc_summary;
    SELECT madlib.graph_apsp('vertex_disc',NULL,'edge_disc',NULL,'out_disc');
    
    SELECT * FROM out_disc_summary;
    SELECT * FROM out_disc ORDER BY src,dest;
    
    select madlib.graph_apsp_get_path('out_disc',1,5,'out_disc_path');
    select * from out_disc_path;
      path   
    ---------
     {1,3,5}
     {1,0,5}
    (2 rows)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #136: Graph: Add APSP with grouping

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-madlib/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---