You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2018/02/02 15:05:00 UTC

[jira] [Commented] (NUMBERS-53) Factory methods are not "static"

    [ https://issues.apache.org/jira/browse/NUMBERS-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350472#comment-16350472 ] 

Gilles commented on NUMBERS-53:
-------------------------------

As per the ongoing discussion on the ML, I suggest to have the following factory methods:
* ofCartesian(double re, double im)
* ofPolar(double modulus, double arg)
* ofCis(double arg)

and to remove _all_ the others:
* createComplex
* polar
* cis
* valueOf

as well as the constructor {{Complex(double)}}.

Also the single remaining constructor should be "private".

> Factory methods are not "static"
> --------------------------------
>
>                 Key: NUMBERS-53
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-53
>             Project: Commons Numbers
>          Issue Type: Bug
>          Components: complex
>            Reporter: Gilles
>            Priority: Blocker
>             Fix For: 1.0
>
>
> * {{polar(x,y)}}
>  * cis(x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)