[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

[clebertsuconic <gi...@git.apache.org>]

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/573
  
    @jbertram 
    
    I will merge it, but if I added this following line in one of these tests:
    
    ```java
       @Rule
       public ThreadLeakCheckRule leakCheckRule = new ThreadLeakCheckRule();
    
    ```
    
    
    The test will have leaked threads from some executor:
    
    
    ```
    LEAKING THREADS
    =============================================================================
    Thread Thread[NioProcessor-1,5,main] is still alive with the following stackTrace:
    sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
    sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
    sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:103)
    sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
    sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
    org.apache.mina.transport.socket.nio.NioProcessor.select(NioProcessor.java:69)
    org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:961)
    org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64)
    java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    java.lang.Thread.run(Thread.java:745)
    =============================================================================
    Thread Thread[pool-4-thread-1,5,main] is still alive with the following stackTrace:
    sun.misc.Unsafe.park(Native Method)
    java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
    java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
    java.util.concurrent.LinkedBlockingQueue.poll(LinkedBlockingQueue.java:467)
    org.apache.mina.filter.executor.UnorderedThreadPoolExecutor$Worker.fetchTask(UnorderedThreadPoolExecutor.java:461)
    org.apache.mina.filter.executor.UnorderedThreadPoolExecutor$Worker.run(UnorderedThreadPoolExecutor.java:413)
    java.lang.Thread.run(Thread.java:745)
    =============================================================================
    Thread Thread[Thread-1,5,main] is still alive with the following stackTrace:
    java.net.SocketInputStream.socketRead0(Native Method)
    java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
    java.net.SocketInputStream.read(SocketInputStream.java:170)
    java.net.SocketInputStream.read(SocketInputStream.java:141)
    java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
    java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
    java.io.BufferedInputStream.read(BufferedInputStream.java:345)
    com.sun.jndi.ldap.Connection.run(Connection.java:860)
    java.lang.Thread.run(Thread.java:745)
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---