You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/21 10:27:12 UTC

[GitHub] [ofbiz-framework] bjugl commented on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

bjugl commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998660121


   > I did not review yet. I suggest we consider to use gradle-npm to load the lib.
   
   Lib is now loaded by gradle-npm.
   
   Trumbowyg uses its own css. Since some classes have attributes that are overwritten in themes, they have to be supplemented with !important tags in two places. 
   
   Thus we have to have an overwrite css. I moved it to "common/css/ ".
   I would like to document this somewhere, because it will propably cause some issues, when the version of trumbowyg changes. Since comments in the package.json are not an option, where would you recommend to put such a comment?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org