[GitHub] [airflow] potiuk commented on a change in pull request #20701: [WIP] Check free space python

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #20701:
URL: https://github.com/apache/airflow/pull/20701#discussion_r781174898



##########
File path: .github/workflows/ci.yml
##########
@@ -603,8 +624,13 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
         uses: actions/setup-python@v2
         with:
           python-version: ${{ env.PYTHON_MAJOR_MINOR_VERSION }}
+      - uses: actions/setup-python@v2
+        with:
+          python-version: '3.7'
+          cache: 'pip'
+      - run: python -m pip install --editable ../../dev/breeze/

Review comment:
       No relation wth that. Our tests will continue using the images (controlled by PYTHON_MAJOR_MINOR_VERSION) variable.
   
   This one is the "Breeze" virtualenv only that has nothing to do with the "airflow" virtualenv. It's only there to run the CI and ./Breeze scripts (it's basically a "common" execution virtualenv that is portable way of running our scripts in any OS - replacing what `Bash` was supposed to do in the original "Breeze". Just common execution (virtual) environment with all dependencies installed that the scripts are using.
   
   For "users" use, this will be installed either automatically by bootstraping script `./Breeze2` or (whe we stabilize dependencie) via `pipx instal --editable ./dev/breeze`. 
   
   More details and reasoning (alternatives considered) are described in this ADR: https://github.com/apache/airflow/blob/main/dev/breeze/doc/adr/0003-bootstraping-virtual-environment.md




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org