You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/23 03:42:19 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12850: fix(lines): lines series shouldn't disappear after `setOption({})`. (#12836)

plainheart opened a new pull request #12850:
URL: https://github.com/apache/incubator-echarts/pull/12850


   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Fixes the bug that lines series will disappear after `setOption({})`, closes #12836.
   
   ### Fixed issues
   
   -  #12836 
   
   ## Details
   
   ### Before: What was the problem?
   
   See #12836
   
   
   ### After: How is it fixed in this PR?
   
   Tweaked `LinesSeries.mergeOption`, removed the code line below
   ```js
   option.data = option.data || [];
   ```
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   Refer to `test/lines-mergeOption.html`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12850: fix(lines): lines series shouldn't disappear after `setOption({})`. (#12836)

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12850:
URL: https://github.com/apache/incubator-echarts/pull/12850#issuecomment-647889185


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #12850: fix(lines): lines series shouldn't disappear after `setOption({})`. (#12836)

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12850:
URL: https://github.com/apache/incubator-echarts/pull/12850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12850: fix(lines): lines series shouldn't disappear after `setOption({})`. (#12836)

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12850:
URL: https://github.com/apache/incubator-echarts/pull/12850#issuecomment-668403870


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org