You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-user@portals.apache.org by "Kimpton,C (Chris)" <Ki...@rabo-bank.com> on 2001/04/30 14:59:33 UTC

RE: jetspeed 1.3a1 / jdk1.3 bug... setting/getting system propert ies

Hi,

Can this patch be applied?

See original post for details of why it is needed/useful.

Chris


> -----Original Message-----
> From: Kimpton,C (Chris) 
> Sent: Friday, 06 April 2001 16:08
> 
> 
> Index: SingletonHolder.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/
> util/SingletonHolder.java,v
> retrieving revision 1.7
> diff -u -r1.7 SingletonHolder.java
> --- SingletonHolder.java        2001/03/07 06:50:05     1.7
> +++ SingletonHolder.java        2001/04/06 15:03:31
> @@ -225,6 +225,18 @@
>          }
> 
>      }
> +
> +    /** HACK TO GET ROUND JDK BUG.
> +    * until the Properties.getProperty version of this
> +    * method is fixed to not use super.get, this can then be removed
> +    **/
> +    public String getProperty(String key) {
> +        Object oval = get(key);
> +        String sval = (oval instanceof String) ? (String)oval : null;
> +        return ((sval == null) && (defaults != null)) ? 
> defaults.getProperty(key) : sval;
> +    }
> +
> +
> 
>      /**
>      Provide information if this class was finalized
> 
> 
> 

================================================================================================
This electronic message (email) and any attachments to it are subject to copyright and are sent for the personal attention of the addressee. Although you may be the named recipient, it may become apparent that this email and its contents are not intended for you and an addressing error has been made. This email may include information that is legally privileged and exempt from disclosure. If you have received this email in error, please advise us immediately and delete this email and any attachments from your computer system.Rabobank International is the trading name of Coöperatieve Centrale Raiffeisen-Boerenleenbank B.A. which is incorporated in the Netherlands. Registered with the Registrar of Companies for England & Wales No. BR002630 and regulated by the SFA for the conduct of investment business in the UK.

The presence of this footnote also confirms that this email has been automatically checked by Rabobank International for the presence of computer viruses prior to it being sent, however, no guarantee is given or implied that this email is virus free upon delivery.



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-user-help@jakarta.apache.org


Re: jetspeed 1.3a1 / jdk1.3 bug... setting/getting system propert ies

Posted by Santiago Gala <sg...@hisitech.com>.
Kimpton,C (Chris) wrote:

> Hi,
> 
> Can this patch be applied?

Done.


> 
> See original post for details of why it is needed/useful.

Sorry, I evaluated it when at Sta. Clara, and forget to apply it.

I think it would be better to use a different implementation of 
SingletonHolder, one that does NOT inherit from Properties. I think this 
was done as a "hack" to avoid singletons being reclaimed by garbage 
collector under jdk1.1.x It does not make a lot of sense now.

But it looks costly to implement right now.


> 
> Chris
> 
> 
> 
>> -----Original Message-----
>> From: Kimpton,C (Chris) 
>> Sent: Friday, 06 April 2001 16:08
>> 
>> 
>> Index: SingletonHolder.java
>> ===================================================================
>> RCS file: 
>> /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/
>> util/SingletonHolder.java,v
>> retrieving revision 1.7
>> diff -u -r1.7 SingletonHolder.java
>> --- SingletonHolder.java        2001/03/07 06:50:05     1.7
>> +++ SingletonHolder.java        2001/04/06 15:03:31
>> @@ -225,6 +225,18 @@
>>          }
>> 
>>      }
>> +
>> +    /** HACK TO GET ROUND JDK BUG.
>> +    * until the Properties.getProperty version of this
>> +    * method is fixed to not use super.get, this can then be removed
>> +    **/
>> +    public String getProperty(String key) {
>> +        Object oval = get(key);
>> +        String sval = (oval instanceof String) ? (String)oval : null;
>> +        return ((sval == null) && (defaults != null)) ? 
>> defaults.getProperty(key) : sval;
>> +    }
>> +
>> +
>> 
>>      /**
>>      Provide information if this class was finalized
>> 
>> 
>> 
> 
> 
> ================================================================================================
> This electronic message (email) and any attachments to it are subject to copyright and are sent for the personal attention of the addressee. Although you may be the named recipient, it may become apparent that this email and its contents are not intended for you and an addressing error has been made. This email may include information that is legally privileged and exempt from disclosure. If you have received this email in error, please advise us immediately and delete this email and any attachments from your computer system.Rabobank International is the trading name of Coöperatieve Centrale Raiffeisen-Boerenleenbank B.A. which is incorporated in the Netherlands. Registered with the Registrar of Companies for England & Wales No. BR002630 and regulated by the SFA for the conduct of investment business in the UK.
> 
> The presence of this footnote also confirms that this email has been automatically checked by Rabobank International for the presence of computer viruses prior to it being sent, however, no guarantee is given or implied that this email is virus free upon delivery.
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jetspeed-user-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-user-help@jakarta.apache.org