[jira] [Resolved] (JCR-3225) ConcurrentModificationException in QueryStatImpl

["Alex Parvulescu (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved JCR-3225.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4

I wasn't able to see the ConcurrentModificationException, but I saw another one on #getPopularQueries: ArrayIndexOutOfBoundsException.
I added some synchronization code to the 2 methods.

Fixed in rev: 1240053.

                
> ConcurrentModificationException in QueryStatImpl
> ------------------------------------------------
>
>                 Key: JCR-3225
>                 URL: https://issues.apache.org/jira/browse/JCR-3225
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.3.6, 2.3.7
>            Reporter: Christan Keller
>             Fix For: 2.4
>
>
> Running with qurystats enabled the Query#execute can throw ConcurrentModificationException
> caused by the iterator which backing collection is changed from another thread
> see logQuery method
>         Iterator<QueryStatDtoImpl> iterator = popularQueries.iterator();
>         while (iterator.hasNext()) {
> -->            QueryStatDtoImpl qsdi = iterator.next();
>             if (qsdi.equals(qs)) {
>                 qs.setOccurrenceCount(qsdi.getOccurrenceCount() + 1);
>                 iterator.remove();
>                 break;
>             }
>         }
>         popularQueries.offer(qs);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira