You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/07/25 04:55:03 UTC

[GitHub] [incubator-iotdb] Ring-k commented on pull request #1544: [IOTDB-810] Set Configuration of Max Number of Logs in Memory

Ring-k commented on pull request #1544:
URL: https://github.com/apache/incubator-iotdb/pull/1544#issuecomment-663809312


   > I think when the max_num_of_logs_in_mem threshold is reached we should delete the logs to min_num_of_logs_in_mem rather than throwing an exception to the client.
   > These two configurations `max_num_of_logs_in_mem` and `log_deletion_check_interval_second ` are both used to ensure that the Raft logs did not take up whole memory rather than slow down the write rate for the client.
   
   I got you. I will change these logics.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org