You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by eo...@apache.org on 2020/11/04 11:11:17 UTC

[bookkeeper] branch master updated: add channel information if catch exception in BookieRequestHandler

This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 9f10dee  add channel information if catch exception in BookieRequestHandler
9f10dee is described below

commit 9f10dee2b170c12d7c700c2610617fe0cba14ee2
Author: Aloys <lo...@gmail.com>
AuthorDate: Wed Nov 4 19:11:07 2020 +0800

    add channel information if catch exception in BookieRequestHandler
    
    ### Motivation
    fix #2475
    add channel information if catch exception in BookieRequestHandler
    
    
    
    
    Reviewers: Anup Ghatage <gh...@apache.org>, Nicolò Boschi <bo...@gmail.com>, Enrico Olivelli <eo...@gmail.com>
    
    This closes #2479 from aloyszhang/add-channel-info
---
 .../main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java
index d2e9548..c4a6dfe 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestHandler.java
@@ -64,10 +64,10 @@ class BookieRequestHandler extends ChannelInboundHandlerAdapter {
     @Override
     public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
         if (cause instanceof ClosedChannelException) {
-            LOG.info("Client died before request could be completed", cause);
+            LOG.info("Client died before request could be completed on {}", ctx.channel(), cause);
             return;
         }
-        LOG.error("Unhandled exception occurred in I/O thread or handler", cause);
+        LOG.error("Unhandled exception occurred in I/O thread or handler on {}", ctx.channel(), cause);
         ctx.close();
     }