You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mohit Sabharwal <mo...@cloudera.com> on 2016/11/17 18:25:43 UTC
Review Request 53838: HIVE-15232: Add notification events for
functions and indexes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53838/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-15232
https://issues.apache.org/jira/browse/HIVE-15232
Repository: hive-git
Description
-------
Adds notification events for Create/Drop Function and Create/Drop/Alter Index.
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java 72930eb66c2b44fc6ee414c40ead713eb83413c1
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 0b3d89198f1d89c057d2639b89799b53b4a09163
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/HCatEventMessage.java 538fa68a83081604ca6598d886021a633dfecea7
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageDeserializer.java 8ea39987f022175f0bcb6e1ecd0945847fd70996
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java 0710dd09dbafb11ce3a4819bc2bd5f50bf70dc84
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageDeserializer.java 834fdde113a293fcc595c8bfe329a9299ae8aabc
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageFactory.java 6b74b54b5d8f3ef8735b8bae5535567a7c4dc76a
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 4a7801bbf010dbcfa2044381cfd2e913f83f5445
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cd32d5859899960337c9525ac033cd1cfb64ab2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0ef25e103d0b7cbb187cea2111efc6a40e01d85
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 5e46ae1d83296d11957038c76ee2e4d207db8992
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java PRE-CREATION
metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java a3b16d049c9c06f08e5ef8809ad386274479d66d
Diff: https://reviews.apache.org/r/53838/diff/
Testing
-------
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal
Re: Review Request 53838: HIVE-15232: Add notification events for
functions and indexes
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53838/
-----------------------------------------------------------
(Updated Nov. 17, 2016, 9:26 p.m.)
Review request for hive.
Changes
-------
Incorp. review feedback.
Bugs: HIVE-15232
https://issues.apache.org/jira/browse/HIVE-15232
Repository: hive-git
Description
-------
Adds notification events for Create/Drop Function and Create/Drop/Alter Index.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java 72930eb66c2b44fc6ee414c40ead713eb83413c1
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 0b3d89198f1d89c057d2639b89799b53b4a09163
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/HCatEventMessage.java 538fa68a83081604ca6598d886021a633dfecea7
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageDeserializer.java 8ea39987f022175f0bcb6e1ecd0945847fd70996
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java 0710dd09dbafb11ce3a4819bc2bd5f50bf70dc84
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageDeserializer.java 834fdde113a293fcc595c8bfe329a9299ae8aabc
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageFactory.java 6b74b54b5d8f3ef8735b8bae5535567a7c4dc76a
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 4a7801bbf010dbcfa2044381cfd2e913f83f5445
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cd32d5859899960337c9525ac033cd1cfb64ab2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0ef25e103d0b7cbb187cea2111efc6a40e01d85
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 5e46ae1d83296d11957038c76ee2e4d207db8992
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java PRE-CREATION
metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java a3b16d049c9c06f08e5ef8809ad386274479d66d
Diff: https://reviews.apache.org/r/53838/diff/
Testing
-------
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal
Re: Review Request 53838: HIVE-15232: Add notification events for
functions and indexes
Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53838/#review156239
-----------------------------------------------------------
Fix it, then Ship it!
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java (line 296)
<https://reviews.apache.org/r/53838/#comment226426>
Nit: remove empty spaces
- Chaoyu Tang
On Nov. 17, 2016, 8:48 p.m., Mohit Sabharwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53838/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2016, 8:48 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15232
> https://issues.apache.org/jira/browse/HIVE-15232
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adds notification events for Create/Drop Function and Create/Drop/Alter Index.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java 72930eb66c2b44fc6ee414c40ead713eb83413c1
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 0b3d89198f1d89c057d2639b89799b53b4a09163
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/HCatEventMessage.java 538fa68a83081604ca6598d886021a633dfecea7
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageDeserializer.java 8ea39987f022175f0bcb6e1ecd0945847fd70996
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java 0710dd09dbafb11ce3a4819bc2bd5f50bf70dc84
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java PRE-CREATION
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageDeserializer.java 834fdde113a293fcc595c8bfe329a9299ae8aabc
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageFactory.java 6b74b54b5d8f3ef8735b8bae5535567a7c4dc76a
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 4a7801bbf010dbcfa2044381cfd2e913f83f5445
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cd32d5859899960337c9525ac033cd1cfb64ab2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0ef25e103d0b7cbb187cea2111efc6a40e01d85
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 5e46ae1d83296d11957038c76ee2e4d207db8992
> metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java PRE-CREATION
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java a3b16d049c9c06f08e5ef8809ad386274479d66d
>
> Diff: https://reviews.apache.org/r/53838/diff/
>
>
> Testing
> -------
>
> Verified using TestDbNotificationListener
>
>
> Thanks,
>
> Mohit Sabharwal
>
>
Re: Review Request 53838: HIVE-15232: Add notification events for
functions and indexes
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53838/
-----------------------------------------------------------
(Updated Nov. 17, 2016, 8:48 p.m.)
Review request for hive.
Changes
-------
Fixed test failure.
Bugs: HIVE-15232
https://issues.apache.org/jira/browse/HIVE-15232
Repository: hive-git
Description
-------
Adds notification events for Create/Drop Function and Create/Drop/Alter Index.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java 72930eb66c2b44fc6ee414c40ead713eb83413c1
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 0b3d89198f1d89c057d2639b89799b53b4a09163
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/HCatEventMessage.java 538fa68a83081604ca6598d886021a633dfecea7
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageDeserializer.java 8ea39987f022175f0bcb6e1ecd0945847fd70996
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java 0710dd09dbafb11ce3a4819bc2bd5f50bf70dc84
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java PRE-CREATION
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageDeserializer.java 834fdde113a293fcc595c8bfe329a9299ae8aabc
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageFactory.java 6b74b54b5d8f3ef8735b8bae5535567a7c4dc76a
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 4a7801bbf010dbcfa2044381cfd2e913f83f5445
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cd32d5859899960337c9525ac033cd1cfb64ab2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0ef25e103d0b7cbb187cea2111efc6a40e01d85
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 5e46ae1d83296d11957038c76ee2e4d207db8992
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java PRE-CREATION
metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java a3b16d049c9c06f08e5ef8809ad386274479d66d
Diff: https://reviews.apache.org/r/53838/diff/
Testing
-------
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal