You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2019/03/29 14:43:50 UTC

[hbase] branch branch-2 updated: HBASE-22073 /rits.jsp throws an exception if no procedure

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 85c17e7  HBASE-22073 /rits.jsp throws an exception if no procedure
85c17e7 is described below

commit 85c17e711cdeb14bbe008a0045ca2540d51df4eb
Author: Balazs Meszaros <ba...@cloudera.com>
AuthorDate: Wed Mar 20 13:12:30 2019 +0100

    HBASE-22073 /rits.jsp throws an exception if no procedure
---
 .../src/main/resources/hbase-webapps/master/rits.jsp   | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/hbase-server/src/main/resources/hbase-webapps/master/rits.jsp b/hbase-server/src/main/resources/hbase-webapps/master/rits.jsp
index 78bc32e..ae5f25c 100644
--- a/hbase-server/src/main/resources/hbase-webapps/master/rits.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/master/rits.jsp
@@ -22,10 +22,11 @@
          import="java.util.Collections"
          import="java.util.Comparator"
          import="java.util.List"
+         import="java.util.stream.Collectors"
          import="org.apache.hadoop.hbase.master.HMaster"
          import="org.apache.hadoop.hbase.master.assignment.RegionStateNode"
+         import="org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure"
 %>
-<%@ page import="java.util.stream.Collectors" %>
 <%
     HMaster master = (HMaster) getServletContext().getAttribute(HMaster.MASTER);
     List<RegionStateNode> rit = master.getAssignmentManager().getRegionsInTransition();
@@ -86,8 +87,17 @@
                 <td><%= regionStateNode.getRegionInfo().getEncodedName() %></td>
                 <td><%= regionStateNode.getRegionInfo().getTable() %></td>
                 <td><%= regionStateNode.getState() %></td>
-                <td><%= regionStateNode.getProcedure().getProcId() %></td>
-                <td><%= escapeXml(regionStateNode.getProcedure().getState().toString() + (regionStateNode.getProcedure().isBypass() ? "(Bypassed)" : "")) %></td>
+                <%
+                    RegionTransitionProcedure procedure = regionStateNode.getProcedure();
+
+                    if (procedure == null) {
+                %>
+                    <td></td>
+                    <td></td>
+                <% } else { %>
+                    <td><%= procedure.getProcId() %></td>
+                    <td><%= escapeXml(procedure.getState().toString() + (procedure.isBypass() ? "(Bypassed)" : "")) %></td>
+                <% } %>
             </tr>
             <% } %>
             <p><%= rit.size() %> region(s) in transition.</p>
@@ -117,4 +127,4 @@
         </p>
     </div>
 </div>
-<% } %>
\ No newline at end of file
+<% } %>