You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/11 09:03:27 UTC
Review Request 24541: Added a JSON::Object::find.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
Diff: https://reviews.apache.org/r/24541/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24541: Added a JSON::Object::find.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 11, 2014, 8:38 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 85-86
> > <https://reviews.apache.org/r/24541/diff/1/?file=657521#file657521line85>
> >
> > Maybe a small comment about the fact that this supports nesting? Doesn't seem implied from the signature.
> >
> > As another example, this doesn't support indexing: a.b[1].c
> >
> > Kind of reminds me of xpath mapped to json: http://goessner.net/articles/JsonPath/
> >
> > Should 'key' be renamed to 'path' to suggest the nested nature?
Added a comment, included a TODO to support indexing.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/#review50208
-----------------------------------------------------------
On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24541/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
>
> Diff: https://reviews.apache.org/r/24541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24541: Added a JSON::Object::find.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/#review50208
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
<https://reviews.apache.org/r/24541/#comment87824>
Maybe a small comment about the fact that this supports nesting? Doesn't seem implied from the signature.
As another example, this doesn't support indexing: a.b[1].c
Kind of reminds me of xpath mapped to json: http://goessner.net/articles/JsonPath/
Should 'key' be renamed to 'path' to suggest the nested nature?
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
<https://reviews.apache.org/r/24541/#comment87826>
Seems like this should be an Error() or None() since it's due to invalid input from the caller and we have a Result?
- Ben Mahler
On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24541/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
>
> Diff: https://reviews.apache.org/r/24541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24541: Added a JSON::Object::find.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/#review50169
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24541/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
>
> Diff: https://reviews.apache.org/r/24541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24541: Added a JSON::Object::find.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 11, 2014, 7:23 a.m., Timothy Chen wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 223
> > <https://reviews.apache.org/r/24541/diff/1/?file=657521#file657521line223>
> >
> > It will be ideal if we can print the found type, but it's fine if it's too much to do as I don't see a simple way to do so.
Added a TODO.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/#review50168
-----------------------------------------------------------
On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24541/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
>
> Diff: https://reviews.apache.org/r/24541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24541: Added a JSON::Object::find.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24541/#review50168
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
<https://reviews.apache.org/r/24541/#comment87763>
It will be ideal if we can print the found type, but it's fine if it's too much to do as I don't see a simple way to do so.
- Timothy Chen
On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24541/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:03 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285
>
> Diff: https://reviews.apache.org/r/24541/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>