Re: [PR] perf: Avoid re-fetching file status from FS for HFile readers [hudi]

["the-other-tim-brown (via GitHub)" <gi...@apache.org>]

the-other-tim-brown commented on code in PR #17709:
URL: https://github.com/apache/hudi/pull/17709#discussion_r2656718951


##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HFileReaderFactory.java:
##########
@@ -107,7 +107,7 @@ private SeekableDataInputStream createInputStream(long fileSize) throws IOExcept
         StoragePath path = fileSource.asLeft();
         byte[] buffer;
         try (SeekableDataInputStream stream = storage.openSeekable(path, false)) {
-          buffer = new byte[(int) storage.getPathInfo(path).getLength()];
+          buffer = new byte[(int) fileSize];

Review Comment:
   @yihua let me know if there is a particular path I can step through to validate this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org