You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/24 23:41:36 UTC

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #10053: [WIP][QNN] Lookup operations for hard to implement operators

AndrewZhaoLuo opened a new pull request #10053:
URL: https://github.com/apache/tvm/pull/10053


   WIP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10053: [WIP][QNN] Lookup operations for hard to implement operators

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10053:
URL: https://github.com/apache/tvm/pull/10053#issuecomment-1021482147


   I think this is an interesting idea. I think moving the lowering to legalization is probably the right call once we have alternative methods. Need to read more into how legalization works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo merged pull request #10053: [QNN] Lookup operations for hard to implement operators

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged pull request #10053:
URL: https://github.com/apache/tvm/pull/10053


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10053: [WIP][QNN] Lookup operations for hard to implement operators

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10053:
URL: https://github.com/apache/tvm/pull/10053#issuecomment-1021673881


   So I don't understand the functional difference between legalization and canonicalization. They seem to be able to be combined into one step?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbrookhart commented on pull request #10053: [WIP][QNN] Lookup operations for hard to implement operators

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #10053:
URL: https://github.com/apache/tvm/pull/10053#issuecomment-1021421496


   Thanks, @AndrewZhaoLuo, this is a really interesting PR!
   
   I'm not 100% sure what the long term correct approach for running these kind of ops. We can talk about Look Up Tables like this, we could do polynomial approximations over the estimated range, or we could talk about casting back to FP32.
   
   I imagine that the most performant solution is going to depend on the hardware target, some ops will be fast for lookup tables, others will do better with polynomial approximations, and others might be faster just casting back to FP32. Perhaps we should make this part of the device-dependent legalization pass, instead of canonicalization? https://github.com/apache/tvm/blob/main/python/tvm/relay/qnn/op/legalizations.py
   
   @masahi @anijain2305 Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10053: [QNN] Lookup operations for hard to implement operators

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10053:
URL: https://github.com/apache/tvm/pull/10053#issuecomment-1021677371


   This is now ready for review cc @mbrookhart @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org