You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/11/04 22:22:25 UTC
[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6238: [TE] Remove maven-shade-plugin and switch from org.reflections to io.classgraph
vincentchenjl opened a new pull request #6238:
URL: https://github.com/apache/incubator-pinot/pull/6238
This PR is achieve following items:
- Remove `maven-shade-plugin` from `thirdeye-dashboard` module
- Switch from `org.reflections` to `io.classgraph` to reflect detection and alert components in `DetectionRegistry` and `DetectionAlertRegistry`
- Remove `ch.qos.logback` from exclusion in the `pom.xml` of `thirdeye-dashboard`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] vincentchenjl commented on pull request #6238: [TE] Remove maven-shade-plugin and switch from org.reflections to io.classgraph
Posted by GitBox <gi...@apache.org>.
vincentchenjl commented on pull request #6238:
URL: https://github.com/apache/incubator-pinot/pull/6238#issuecomment-722636179
> Quick Question: Does this new library work with higher versions of Java. org.reflections had issues with Java 9 ad above.
Yes, the new library works with Java 9 based on their wiki.
https://github.com/classgraph/classgraph/wiki#use-as-a-module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6238: [TE] Remove maven-shade-plugin and switch from org.reflections to io.classgraph
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6238:
URL: https://github.com/apache/incubator-pinot/pull/6238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jenya commented on pull request #6238: [TE] Remove maven-shade-plugin and switch from org.reflections to io.classgraph
Posted by GitBox <gi...@apache.org>.
jenya commented on pull request #6238:
URL: https://github.com/apache/incubator-pinot/pull/6238#issuecomment-724575261
@vincentchenjl is it expected that removing maven-shade-plugin broke all run scripts (run-frontend.sh, run-backend.sh and docker)?
Build doesn't produce fat jar in `./target/thirdeye-dashboard-1.0.0-SNAPSHOT.jar`. This jar is used by all run scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org