You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/24 20:55:15 UTC
[GitHub] [pulsar] aahmed-se opened a new pull request #5931: Add github
workflow to generate python wheel artifacts
aahmed-se opened a new pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361250186
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
Review comment:
for releases we can add additional event types
https://developer.github.com/v3/activity/events/types/#createevent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361240014
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
Review comment:
how do we trigger this workflow for releases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-568818330
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361239961
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+
+ build-wheel:
+ name: build-wheel
+ runs-on: macos-latest
Review comment:
we need to generate python clients for multiple osx versions, not just the latest mac. How can we do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-568958924
@sijie Here is what I used in the past
https://github.com/aahmed-se/pulsar-ci-test/blob/master/azure-pipelines.yml
https://dev.azure.com/alahmedse/apache-pulsar/_build/results?buildId=90&view=artifacts&type=publishedArtifacts
we can't put it in apache since apache projects can't work with azure pipelines.
Also @merlimat already has a pr out to fix some issues that should be merged before we release python artifacts for mac it fixes issues relating to linking brew specific paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361240119
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+
+ build-wheel:
+ name: build-wheel
+ runs-on: macos-latest
+ timeout-minutes: 15
+
+ steps:
+ - name: checkout
+ uses: actions/checkout@v1
+
+ - name: brew pakages
+ run: brew install boost-python3 protobuf python jsoncpp openssl zlib
+
+ - name: build wheel file
+ run: |
+ cd pulsar-client-cpp
+ cmake . -DBUILD_TESTS=OFF \
+ -DLINK_STATIC=ON \
+ -DPYTHON_LIBRARY=/usr/local/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7.dylib \
+ -DPYTHON_INCLUDE_DIR=/usr/local/Frameworks/Python.framework/Versions/3.7/include/python3.7m
+ make _pulsar -j8
+ cd python
+ python3 setup.py bdist_wheel
+ cd ../..
+
+ - uses: actions/upload-artifact@master
+ name: upload wheel artifact
+ with:
+ name: python-wheel-artifacts
+ path: pulsar-client-cpp/python/dist
Review comment:
where are these artifacts uploaded to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361250270
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+
+ build-wheel:
+ name: build-wheel
+ runs-on: macos-latest
+ timeout-minutes: 15
+
+ steps:
+ - name: checkout
+ uses: actions/checkout@v1
+
+ - name: brew pakages
+ run: brew install boost-python3 protobuf python jsoncpp openssl zlib
+
+ - name: build wheel file
+ run: |
+ cd pulsar-client-cpp
+ cmake . -DBUILD_TESTS=OFF \
+ -DLINK_STATIC=ON \
+ -DPYTHON_LIBRARY=/usr/local/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7.dylib \
+ -DPYTHON_INCLUDE_DIR=/usr/local/Frameworks/Python.framework/Versions/3.7/include/python3.7m
+ make _pulsar -j8
+ cd python
+ python3 setup.py bdist_wheel
+ cd ../..
+
+ - uses: actions/upload-artifact@master
+ name: upload wheel artifact
+ with:
+ name: python-wheel-artifacts
+ path: pulsar-client-cpp/python/dist
Review comment:
In github it self it's in the job run
https://github.com/apache/pulsar/pull/5931/checks?check_run_id=362655254 top right hand corner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-569235893
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-569236274
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361250424
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+
+ build-wheel:
+ name: build-wheel
+ runs-on: macos-latest
Review comment:
github only supports osx 10.15, one option is to use azure pipelines which has osx10.14 also but better option would be to change the setup.py and cmake files to build for older versions of osx on 10.15, it's doable requires setting a few environments variables and custom linker flags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r363151987
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
Review comment:
I don't think we should upload the wheel files to PyPI on pull requests. It should be on releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361240069
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
Review comment:
we need to run this on release tags, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-568818324
run java8 tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #5931: Add
github workflow to generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#discussion_r361250193
##########
File path: .github/workflows/python-whl-osx.yaml
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Python 37 wheel osx
+on:
+ pull_request:
+ branches:
+ - master
Review comment:
yes we can add that
https://developer.github.com/v3/activity/events/types/#createevent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5931: Add github workflow to
generate python wheel artifacts
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #5931: Add github workflow to generate python wheel artifacts
URL: https://github.com/apache/pulsar/pull/5931#issuecomment-568833664
@aahmed-se : I think you should have provided the instructions of building and publishing python clients using the Azure pipeline that you and @merlimat used before. Because we need to publish macos clients for 2.4.2 and 2.5.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services