You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/10/06 20:54:51 UTC
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 2:54 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Changes
-------
Apologies - I've got 5 different changes open in RB, and I accidentally based this diff against the wrong one. I'll have the correct diff uploaded in a couple of minutes.
Summary (updated)
-----------------
Improve handling of unknown errors in the aurora client.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
-------
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack on the user's terminal, or
absorbing the error and generating a brief error
message, the client now writes detailed information about
the error is written into an error log file, and the
user is given a clean error message referring them to that
file for details.
Diffs
-----
src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c
src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8
src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69
src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26328/diff/
Testing
-------
New unit test.
Thanks,
Mark Chu-Carroll
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Oct. 8, 2014, 1:58 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 435
> > <https://reviews.apache.org/r/26328/diff/2/?file=714194#file714194line435>
> >
> > It writes into the current directory where the user is executing the client.
This is going to lead to complaints. On the dev list, John wrote:
"The full backtrace goes off to a file in the user's home dir somewhere and
then you can ask them to run a command passing the pill ref to get the full
error report without worry of re-running some non-idempotent command, etc."
So I really think we should write them to a consistent and predictable location.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55794
-----------------------------------------------------------
On Oct. 8, 2014, 2:42 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 2:42 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55794
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96178>
It writes into the current directory where the user is executing the client.
- Mark Chu-Carroll
On Oct. 6, 2014, 2:55 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 2:55 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
> src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55553
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Oct. 6, 2014, 11:55 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 11:55 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
> src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 8, 2014, 1:05 a.m., Maxim Khutornenko wrote:
> >
I see this got committed even though there are still open questions in this RB. Any chance these can get answered?
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55752
-----------------------------------------------------------
On Oct. 8, 2014, 2:42 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 2:42 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55752
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96140>
This will also catch KeyboardInterrupt, which is the main source of annoying stack noise. Consider filtering it out to prevent false positives.
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96142>
s/returnen/returned/g
src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96147>
Is it writing into the current dir of the aurora.pex executable? Consider making root path configurable instead with a more durable default value (e.g. somewhere under ~/). Otherwise, the error reports are gone the very moment aurora version is upgraded by an automated process (e.g. rsync).
- Maxim Khutornenko
On Oct. 6, 2014, 6:55 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 6:55 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
> src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 10:42 a.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Changes
-------
Rebase.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
-------
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack on the user's terminal, or
absorbing the error and generating a brief error
message, the client now writes detailed information about
the error is written into an error log file, and the
user is given a clean error message referring them to that
file for details.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
Diff: https://reviews.apache.org/r/26328/diff/
Testing
-------
New unit test.
Thanks,
Mark Chu-Carroll
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55749
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 6:55 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 6:55 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve handling of unknown errors in the aurora client.
>
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
> src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064
> src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
> src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
> src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
>
> Diff: https://reviews.apache.org/r/26328/diff/
>
>
> Testing
> -------
>
> New unit test.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26328: Improve handling of unknown errors in the
aurora client.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 2:55 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Changes
-------
Rebase the changes against the correct branch.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
-------
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack on the user's terminal, or
absorbing the error and generating a brief error
message, the client now writes detailed information about
the error is written into an error log file, and the
user is given a clean error message referring them to that
file for details.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2
src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064
src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af
src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2
src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3
src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26328/diff/
Testing
-------
New unit test.
Thanks,
Mark Chu-Carroll