[jira] [Updated] (GIRAPH-25) NPE in BspServiceMaster when failing a job

["Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GIRAPH-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated GIRAPH-25:
------------------------------------

    Attachment: GIRAPH-25.patch

Attached a basic fix.

The problem was that failing the job did everything correctly, but did not stop BspServiceMaster to proceed. 

There are two choices here -- declare an exception and throw it in this case, and deal with that upstream; or, c-style, return a -1. I chose the latter because it makes code that deals with this more succinct and it didn't change a public api. But I can rewrite if you prefer to throw an exception.

No test as I wasn't sure how best to fit this into the way the tests are set up.

> NPE in BspServiceMaster when failing a job
> ------------------------------------------
>
>                 Key: GIRAPH-25
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-25
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Priority: Minor
>         Attachments: GIRAPH-25.patch
>
>
> When BspServiceMaster times out waiting for all workers to check in, it dies with a NullPointerException.
> This can perhaps be handled a bit more gracefully.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira