You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2025/08/23 09:36:59 UTC
[PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
rawwar opened a new pull request, #54865:
URL: https://github.com/apache/airflow/pull/54865
closes #53043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #54865:
URL: https://github.com/apache/airflow/pull/54865#issuecomment-3289154776
There are conflicts to resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar closed pull request #54865: [Filters] Add filtering support to Search – DAG Runs
URL: https://github.com/apache/airflow/pull/54865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2307509455
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/dags.json:
##########
@@ -20,7 +21,7 @@
"all": "All",
"paused": "Paused"
},
- "runIdPatternFilter": "Search Dag Runs",
+ "runIdPatternFilter": "Search by Dag Runs",
Review Comment:
If we're gonna change this. Let's be more precise. "Search by Dag Run Id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2315966236
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
Review Comment:
<img width="1840" height="354" alt="Screenshot 2025-09-02 at 14 41 07" src="https://github.com/user-attachments/assets/717ce3c2-c5ce-485b-8c51-7f4382f7472b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2307513817
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
+ <Button
+ _hover={{ bg: "red.600" }}
+ bg="red.700"
+ borderColor="red.500"
Review Comment:
We don't use red for clearing filters anywhere else. Let's not do it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2334807705
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
Review Comment:
It could be like this:
https://github.com/user-attachments/assets/e2a16e5c-095b-4cbe-8f0d-9d32e89b7c44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on PR #54865:
URL: https://github.com/apache/airflow/pull/54865#issuecomment-3294417013
closing this PR as @RoyLee1224 will be picking it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2334804549
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
Review Comment:
To address the issues @pierrejeambrun mentioned earlier, we could add `filterCount` for conditional reset button and modify the styling like this:
```suggestion
<Box alignSelf="end">
{filterCount > 0 && (
<Button onClick={handleResetFilters} size="sm" variant="outline">
<LuX />
{translate("common:table.filterReset", { count: filterCount })}
</Button>
)}
</Box>
```
See `XComFilters.tsx` lines 148-158 and 212-217 for the reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #54865:
URL: https://github.com/apache/airflow/pull/54865#issuecomment-3293981218
Do you think you could rebase to use `FilterBar` too? At least for the date and string inputs. We can do the dropdowns later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2334807705
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
Review Comment:
It would be like this:
https://github.com/user-attachments/assets/e2a16e5c-095b-4cbe-8f0d-9d32e89b7c44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2307956530
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
+ <Button
+ _hover={{ bg: "red.600" }}
+ bg="red.700"
+ borderColor="red.500"
Review Comment:
I actually asked it to make it red. It is easy to find on the page in both light and dark mode. But, I'll stick to the current way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2315963392
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
Review Comment:
Maybe all of the filters should be on the same 'row' and we wrap as needed, similarly to what we have for xcom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2334804549
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
Review Comment:
I think we could add `filterCount` for conditional reset button (see `XComFilters.tsx`:138)
```suggestion
<Box alignSelf="end">
{filterCount > 0 && (
<Button onClick={handleResetFilters} size="sm" variant="outline">
<LuX />
{translate("common:table.filterReset", { count: filterCount })}
</Button>
)}
</Box>
```
See `XComFilters.tsx` lines 148-158 and 212-217 for the reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2307511848
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
+ <Button
+ _hover={{ bg: "red.600" }}
+ bg="red.700"
+ borderColor="red.500"
+ borderRadius="md"
+ color="white"
+ ml={2}
+ onClick={() => {
+ searchParams.forEach((_, key) => searchParams.delete(key));
+ setTableURLState({
+ pagination: { ...pagination, pageIndex: 0 },
+ sorting: [],
+ });
+ setSearchParams(searchParams);
+ }}
+ px={3}
+ py={1.5}
+ type="button"
+ >
+ {translate("common:filters.clearAllFilters", "Clear Filters")}
Review Comment:
Why the "Clear Filters"?
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
+ <Button
+ _hover={{ bg: "red.600" }}
+ bg="red.700"
+ borderColor="red.500"
+ borderRadius="md"
+ color="white"
+ ml={2}
+ onClick={() => {
+ searchParams.forEach((_, key) => searchParams.delete(key));
+ setTableURLState({
+ pagination: { ...pagination, pageIndex: 0 },
+ sorting: [],
+ });
+ setSearchParams(searchParams);
+ }}
+ px={3}
+ py={1.5}
+ type="button"
+ >
+ {translate("common:filters.clearAllFilters", "Clear Filters")}
Review Comment:
Why the "Clear Filters" raw string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Filters] Add filtering support to Search – DAG Runs [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #54865:
URL: https://github.com/apache/airflow/pull/54865#discussion_r2307809328
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -364,6 +433,108 @@ export const DagRuns = () => {
</Select.Content>
</Select.Root>
</HStack>
+ <HStack flexWrap="wrap" gap={6} paddingY="4px">
+ {/* Start Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(event.target.value, startDateLte ?? "")}
+ size="sm"
+ value={startDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.startDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleStartDateRangeChange(startDateGte ?? "", event.target.value)}
+ size="sm"
+ value={startDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* End Date Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(event.target.value, endDateLte ?? "")}
+ size="sm"
+ value={endDateGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.endDateToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleEndDateRangeChange(endDateGte ?? "", event.target.value)}
+ size="sm"
+ value={endDateLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Run After Range */}
+ <Box>
+ <HStack alignItems="flex-start">
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterFromPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(event.target.value, runAfterLte ?? "")}
+ size="sm"
+ value={runAfterGte ?? ""}
+ />
+ </Box>
+ <Box w="180px">
+ <Box marginBottom={1} minHeight="1.2em">
+ <Text fontSize="xs">{translate("common:filters.runAfterToPlaceholder")}</Text>
+ </Box>
+ <DateTimeInput
+ onChange={(event) => handleRunAfterRangeChange(runAfterGte ?? "", event.target.value)}
+ size="sm"
+ value={runAfterLte ?? ""}
+ />
+ </Box>
+ </HStack>
+ </Box>
+ {/* Clear Filters Button */}
+ <Box alignItems="flex-end" display="flex" height="100%">
+ <Button
+ _hover={{ bg: "red.600" }}
+ bg="red.700"
+ borderColor="red.500"
Review Comment:
cursor was getting creative ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org