You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/25 09:09:09 UTC

[GitHub] [rocketmq] yazong opened a new pull request #2628: [ISSUE #503] modify rocketmq-console trackType 

yazong opened a new pull request #2628:
URL: https://github.com/apache/rocketmq/pull/2628


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   fix the issue of #503
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   the rocketmq-console trackType is displayed correctly.
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yazong commented on a change in pull request #2628: [ISSUE #503] modify rocketmq-console trackType

Posted by GitBox <gi...@apache.org>.
yazong commented on a change in pull request #2628:
URL: https://github.com/apache/rocketmq/pull/2628#discussion_r564227233



##########
File path: tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##########
@@ -37,58 +24,32 @@
 import org.apache.rocketmq.client.impl.MQClientManager;
 import org.apache.rocketmq.client.impl.factory.MQClientInstance;
 import org.apache.rocketmq.client.log.ClientLogger;
-import org.apache.rocketmq.common.MixAll;
-import org.apache.rocketmq.common.PlainAccessConfig;
-import org.apache.rocketmq.common.ServiceState;
-import org.apache.rocketmq.common.TopicConfig;
-import org.apache.rocketmq.common.AclConfig;
-import org.apache.rocketmq.common.UtilAll;
-import org.apache.rocketmq.common.admin.ConsumeStats;
-import org.apache.rocketmq.common.admin.OffsetWrapper;
-import org.apache.rocketmq.common.admin.RollbackStats;
-import org.apache.rocketmq.common.admin.TopicOffset;
-import org.apache.rocketmq.common.admin.TopicStatsTable;
+import org.apache.rocketmq.common.*;

Review comment:
       is it correct? the trackType ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2628: [ISSUE #503] modify rocketmq-console trackType

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2628:
URL: https://github.com/apache/rocketmq/pull/2628#issuecomment-767557263


   
   [![Coverage Status](https://coveralls.io/builds/36602332/badge)](https://coveralls.io/builds/36602332)
   
   Coverage decreased (-0.03%) to 51.635% when pulling **b96e772d0c5a515d58b5f162ddd9a40c1ecba67a on yazong:develop** into **d8f88c51eb50e43a6bce3fce1ed14f49714ff108 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on a change in pull request #2628: [ISSUE #503] modify rocketmq-console trackType

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on a change in pull request #2628:
URL: https://github.com/apache/rocketmq/pull/2628#discussion_r564223602



##########
File path: tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##########
@@ -37,58 +24,32 @@
 import org.apache.rocketmq.client.impl.MQClientManager;
 import org.apache.rocketmq.client.impl.factory.MQClientInstance;
 import org.apache.rocketmq.client.log.ClientLogger;
-import org.apache.rocketmq.common.MixAll;
-import org.apache.rocketmq.common.PlainAccessConfig;
-import org.apache.rocketmq.common.ServiceState;
-import org.apache.rocketmq.common.TopicConfig;
-import org.apache.rocketmq.common.AclConfig;
-import org.apache.rocketmq.common.UtilAll;
-import org.apache.rocketmq.common.admin.ConsumeStats;
-import org.apache.rocketmq.common.admin.OffsetWrapper;
-import org.apache.rocketmq.common.admin.RollbackStats;
-import org.apache.rocketmq.common.admin.TopicOffset;
-import org.apache.rocketmq.common.admin.TopicStatsTable;
+import org.apache.rocketmq.common.*;

Review comment:
       It will be better not to merge import




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org