You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 14:55:24 UTC

[GitHub] [superset] dungdm93 commented on pull request #20152: refactor(trino): Handful of updates for the Trino engine

dungdm93 commented on PR #20152:
URL: https://github.com/apache/superset/pull/20152#issuecomment-1192657809

   @john-bodley, @zhaoyongjie guys. Trino engine using [`sqlalchemy-trino`](https://github.com/dungdm93/sqlalchemy-trino/) and now official [`trino-python-client`](https://github.com/trinodb/trino-python-client/) driver. Unlike Presto and Hive which are based on PyHive.
   I'm not sure make Trino inherit from `PrestoEngineSpec` is good or should we leave it going its own path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org