You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/10/26 14:41:29 UTC
[commons-compress] 01/04: Precompile regualr expression in ArArchiveInputStream.isBSDLongName(String)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 7e5378737a3c83f0cfd1fc240e28ae6df71e36df
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Oct 26 10:16:28 2023 -0400
Precompile regualr expression in
ArArchiveInputStream.isBSDLongName(String)
---
src/changes/changes.xml | 1 +
.../apache/commons/compress/archivers/ar/ArArchiveInputStream.java | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 0c65d5ef..6e1b7cfe 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -64,6 +64,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="add" dev="ggregory" due-to="Gary Gregory">Add GzipUtils.getUncompressedFileName(String) and deprecate getUncompressedFilename(String).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add GzipUtils.isCompressedFileName(String) and deprecate isCompressedFilename(String).</action>
<!-- FIX -->
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile regualr expression in ArArchiveInputStream.isBSDLongName(String).</action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Dependabot">Bump org.slf4j:slf4j-api from 2.0.8 to 2.0.9 #413.</action>
<action type="update" dev="ggregory" due-to="Gary Gregory">Bump commons-io:commons-io from 2.13.0 to 2.15.0.</action>
diff --git a/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java b/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java
index 08b03cd3..bbea19a4 100644
--- a/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStream.java
@@ -22,6 +22,7 @@ import java.io.EOFException;
import java.io.IOException;
import java.io.InputStream;
import java.util.Arrays;
+import java.util.regex.Pattern;
import org.apache.commons.compress.archivers.ArchiveEntry;
import org.apache.commons.compress.archivers.ArchiveInputStream;
@@ -55,8 +56,7 @@ public class ArArchiveInputStream extends ArchiveInputStream {
static final String BSD_LONGNAME_PREFIX = "#1/";
private static final int BSD_LONGNAME_PREFIX_LEN =
BSD_LONGNAME_PREFIX.length();
- private static final String BSD_LONGNAME_PATTERN =
- "^" + BSD_LONGNAME_PREFIX + "\\d+";
+ private static final Pattern BSD_LONGNAME_PATTERN = Pattern.compile("^" + BSD_LONGNAME_PREFIX + "\\d+");
private static final String GNU_STRING_TABLE_NAME = "//";
private static final String GNU_LONGNAME_PATTERN = "^/\\d+";
/**
@@ -82,7 +82,7 @@ public class ArArchiveInputStream extends ArchiveInputStream {
* @since 1.3
*/
private static boolean isBSDLongName(final String name) {
- return name != null && name.matches(BSD_LONGNAME_PATTERN);
+ return name != null && BSD_LONGNAME_PATTERN.matcher(name).matches();
}
/**