You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/21 22:12:38 UTC

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6951: Update JSON datatype test cases + minor JSON index bug fix.

amrishlal commented on a change in pull request #6951:
URL: https://github.com/apache/incubator-pinot/pull/6951#discussion_r637259747



##########
File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDataTypeQueriesTest.java
##########
@@ -123,6 +118,14 @@ public void setUp()
         "{\"name\": {\"first\": \"goofy\", \"last\": \"dwag\"}, \"id\": 171, \"data\": [\"k\", \"b\", \"c\", \"d\"]}"));
     records.add(createRecord(9, "ludwik von drake",
         "{\"name\": {\"first\": \"ludwik\", \"last\": \"von drake\"}, \"id\": 181, \"data\": [\"l\", \"b\", \"c\", \"d\"]}"));
+    records.add(createRecord(10, "nested array",
+        "{\"name\":{\"first\":\"nested\",\"last\":\"array\"},\"id\":111,\"data\":[{\"e\":[{\"x\":[{\"i1\":1,\"i2\":2}]},{\"y\":[{\"i1\":1,\"i2\":2}]},{\"z\":[{\"i1\":1,\"i2\":2}]}]},{\"b\":[{\"x\":[{\"i1\":1,\"i2\":2}]},{\"y\":[{\"i1\":1,\"i2\":2}]},{\"z\":[{\"i1\":10,\"i2\":20}]}]}]}"));

Review comment:
       Yeah, I was trying to make the code less verbose. I just copy and paste it into https://jsonlint.com/ in browser window for ease of viewing. I haven't tried it yet, but this looks useful too: https://plugins.jetbrains.com/plugin/9679-json-viewer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org