[jira] [Updated] (PHOENIX-2528) Pherf JVM doesn't exit due to un-closed ThreadPool

["Josh Elser (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser updated PHOENIX-2528:
--------------------------------
    Attachment: PHOENIX-2528.patch

Attached patch...

* Closes the pool in WriteWorkLoad.
* Removes the unnecessary (and incorrect) System.exit call.
* Ignores classpath entries (looking for schema/scenario) that are purely whitespace (instead of just the empty string).

> Pherf JVM doesn't exit due to un-closed ThreadPool
> --------------------------------------------------
>
>                 Key: PHOENIX-2528
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2528
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>         Attachments: PHOENIX-2528.patch
>
>
> In trying to use the pherf tool in "cluster" mode, the invocation of {{Pherf}} never exited. I had removed a {{System.exit(0)}} already because it was suppressing an Exception.
> The JVM never exited because there were a number of threads (8) still running and not marked as daemon. After a while, I finally tracked down these threads to {{WriteWorkload}} which didn't bother to close the pool.
> I believe the System.exit was forcing the JVM to exit instead of letting it exit naturally.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)