You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/17 14:06:01 UTC

[GitHub] [incubator-nuttx] juniskane commented on pull request #2325: arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom f…

juniskane commented on pull request #2325:
URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-728950144


   @davids5 : unfortunately not really tested DMA + flow control with upstream NuttX because for that STM32L1 needs the functionality reverted by df9ae3c13f. It would be great if someone could test this with F3 and F4 (I have no board). But isn't the correct thing here to enable/disable the DMA, as uart_enablerxint() and uart_disablerxint() helper macros do, not the interrupt?
   
   The original code cannot be deemed correct either, as it does not even compile when SERIAL_HAVE_ONLY_DMA is true, as up_rxint() is not defined then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org