You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/03 16:29:56 UTC
[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request
#4059: [TE] Improve logging messages; put default ref links only when empty
xiaohui-sun commented on a change in pull request #4059: [TE] Improve logging messages; put default ref links only when empty
URL: https://github.com/apache/incubator-pinot/pull/4059#discussion_r271828358
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineScheduler.java
##########
@@ -82,7 +82,7 @@ public void run() {
try {
if (scheduler.checkExists(key)) {
- LOG.info("Detection config " + key + " is already scheduled.");
+ LOG.info("Detection config " + key.getName() + " is already scheduled");
Review comment:
Can you keep both? Having key is easier to debug. E.g, you can quickly look up key in database.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org