[GitHub] [spark] squito commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r333194793
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
 ##########
 @@ -181,6 +182,7 @@ class RDDStorageInfo private[spark](
     val partitions: Option[Seq[RDDPartitionInfo]])
 
 class RDDDataDistribution private[spark](
+    val executorId: String,
 
 Review comment:
   the api versioning requirements are listed here: https://spark.apache.org/docs/latest/monitoring.html#api-versioning-policy
   
   > New fields may be added to existing endpoints
   
   so its OK to add new fields.
   
   but, if we're adding things that really don't make sense as part of the api, then maybe we should just store a different object instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org