You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Andrzej Rusin (JIRA)" <se...@james.apache.org> on 2012/12/04 12:44:58 UTC

[jira] [Updated] (JAMES-1441) Un-staticize the org.apache.james.mailbox.store.search.MessageSearches

     [ https://issues.apache.org/jira/browse/JAMES-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Rusin updated JAMES-1441:
---------------------------------

    Attachment: JAMES-1441.patch

Patch resolving the issue (without un-privatising yet)
It does not change anything substantial, but I think that goals A and C are a bit important
                
> Un-staticize the org.apache.james.mailbox.store.search.MessageSearches
> ----------------------------------------------------------------------
>
>                 Key: JAMES-1441
>                 URL: https://issues.apache.org/jira/browse/JAMES-1441
>             Project: James Server
>          Issue Type: Improvement
>          Components: MailStore & MailRepository
>    Affects Versions: Trunk
>         Environment: all
>            Reporter: Andrzej Rusin
>            Priority: Trivial
>         Attachments: JAMES-1441.patch
>
>
> To allow some overriding, and also make it more elegant, the following would be nice:
> A convert the static methods to non-static,
> B convert certain methods from private to protected,
> C remove the main processing from the constructor (necessary for A, and also a good practice)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org