[GitHub] KellenSunderland commented on a change in pull request #11325: [MXNET-703] TensorRT runtime integration

[GitBox <gi...@apache.org>]

KellenSunderland commented on a change in pull request #11325: [MXNET-703] TensorRT runtime integration
URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r207015977
 
 

 ##########
 File path: src/executor/exec_pass.h
 ##########
 @@ -198,6 +198,29 @@ Graph InferStorageType(Graph&& graph,
                        StorageTypeVector&& storage_type_inputs = StorageTypeVector(),
                        const std::string& storage_type_attr_key = "");
 
+/*! \brief The default storage type inference function, which assigns all undefined
+ *         storage types to kDefaultStorage. If all of input and output storage types
+ *         are kDefaultStorage, DispatchMode::kFCompute is assigned to dispatch_mode. Otherwise,
+ *         DispatchMode::kFComputeFallback is assigned to dispatch_mode.
+ */
+bool DefaultStorageType(const nnvm::NodeAttrs& attrs,
 
 Review comment:
   This declaration seems to be duplicated from here: https://github.com/apache/incubator-mxnet/blob/0d5ebe169c61f2f12daacfdc16e575f16dc9cb21/src/common/exec_utils.h#L224  I wonder if it's been refactored and this is a merge error?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services