You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/02 01:15:24 UTC
[GitHub] [pulsar] shibd commented on a diff in pull request #15880: [improve][broker] Make some operation subscription dispatchRate methods in Namespaces async
shibd commented on code in PR #15880:
URL: https://github.com/apache/pulsar/pull/15880#discussion_r887417675
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -823,7 +823,7 @@ public void setDispatchRate(@PathParam("property") String property, @PathParam("
@ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist")})
public DispatchRate getDispatchRate(@PathParam("property") String property, @PathParam("cluster") String cluster,
- @PathParam("namespace") String namespace) {
+ @PathParam("namespace") String namespace) {
Review Comment:
invalid change.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -772,7 +772,7 @@ public void deleteDispatchRate(@PathParam("tenant") String tenant, @PathParam("n
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist") })
public DispatchRate getDispatchRate(@PathParam("tenant") String tenant,
- @PathParam("namespace") String namespace) {
+ @PathParam("namespace") String namespace) {
Review Comment:
invalid change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org