You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/23 13:02:15 UTC

[GitHub] [mynewt-nimble] sjanc opened a new pull request #779: Fixes for 1.3 release

sjanc opened a new pull request #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779
 
 
   This fixes dates, license headers and NOTICE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779#issuecomment-602748459
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc merged pull request #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779#issuecomment-602579674
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/host/mesh/src/nodes.h
   <details>
   
   ```diff
   @@ -19,5 +19,5 @@
    
    struct bt_mesh_node *bt_mesh_node_find(u16_t addr);
    struct bt_mesh_node *bt_mesh_node_alloc(u16_t addr, u8_t num_elem,
   -					u16_t net_idx);
   +                                        u16_t net_idx);
    void bt_mesh_node_del(struct bt_mesh_node *node, bool store);
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc removed a comment on issue #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
sjanc removed a comment on issue #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779#issuecomment-602575836
 
 
   @justinmclean could you have a look at this PR? If this is good I'll work on cleaning up core too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] sjanc commented on issue #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
sjanc commented on issue #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779#issuecomment-602575836
 
 
   @justinmclean could you have a look at this PR? If this is good I'll work on cleaning up core too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #779: Fixes for 1.3 release

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779#issuecomment-602579674
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/host/mesh/src/nodes.h
   <details>
   
   ```diff
   @@ -19,5 +19,5 @@
    
    struct bt_mesh_node *bt_mesh_node_find(u16_t addr);
    struct bt_mesh_node *bt_mesh_node_alloc(u16_t addr, u8_t num_elem,
   -					u16_t net_idx);
   +                                        u16_t net_idx);
    void bt_mesh_node_del(struct bt_mesh_node *node, bool store);
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services