You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/17 05:17:43 UTC
[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1389: chore(deps): bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.1 in /test/e2e
dependabot[bot] opened a new pull request, #1389:
URL: https://github.com/apache/apisix-ingress-controller/pull/1389
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.2.0 to 2.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.3.1</h2>
<h2>2.3.1</h2>
<h2>Fixes</h2>
<p>Several users were invoking <code>ginkgo</code> by installing the latest version of the cli via <code>go install github.com/onsi/ginkgo/v2/ginkgo@latest</code>. When 2.3.0 was released this resulted in an influx of issues as CI systems failed due to a change in the internal contract between the Ginkgo CLI and the Ginkgo library. Ginkgo only supports running the same version of the library as the cli (which is why both are packaged in the same repository).</p>
<p>With this patch release, the ginkgo CLI can now identify a version mismatch and emit a helpful error message.</p>
<ul>
<li>Ginkgo cli can identify version mismatches and emit a helpful error message [bc4ae2f]</li>
<li>further emphasize that a version match is required when running Ginkgo on CI and/or locally [2691dd8]</li>
</ul>
<h2>Maintenance</h2>
<ul>
<li>bump gomega to v1.22.0 [822a937]</li>
</ul>
<h2>v2.3.0</h2>
<h2>2.3.0</h2>
<h3>Interruptible Nodes and Timeouts</h3>
<p>Ginkgo now supports per-node and per-spec timeouts on interruptible nodes. Check out the <a href="https://onsi.github.io/ginkgo/#spec-timeouts-and-interruptible-nodes">documentation for all the details</a> but the gist is you can now write specs like this:</p>
<pre lang="go"><code>It("is interruptible", func(ctx SpecContext) { // or context.Context instead of SpecContext, both are valid.
// do things until `ctx.Done()` is closed, for example:
req, err := http.NewRequestWithContext(ctx, "POST", "/build-widgets", nil)
Expect(err).NotTo(HaveOccured())
_, err := http.DefaultClient.Do(req)
Expect(err).NotTo(HaveOccured())
<pre><code>Eventually(client.WidgetCount).WithContext(ctx).Should(Equal(17))
</code></pre>
<p>}, NodeTimeout(time.Second<em>20), GracePeriod(5</em>time.Second))
</code></pre></p>
<p>and have Ginkgo ensure that the node completes before the timeout elapses. If it does elapse, or if an external interrupt is received (e.g. <code>^C</code>) then Ginkgo will cancel the context and wait for the Grace Period for the node to exit before proceeding with any cleanup nodes associated with the spec. The <code>ctx</code> provided by Ginkgo can also be passed down to Gomega's <code>Eventually</code> to have all assertions within the node governed by a single deadline.</p>
<h3>Features</h3>
<ul>
<li>Ginkgo now records any additional failures that occur during the cleanup of a failed spec. In prior versions this information was quietly discarded, but the introduction of a more rigorous approach to timeouts and interruptions allows Ginkgo to better track subsequent failures.</li>
<li><code>SpecContext</code> also provides a mechanism for third-party libraries to provide additional information when a Progress Report is generated. Gomega uses this to provide the current state of an <code>Eventually().WithContext()</code> assertion when a Progress Report is requested.</li>
<li>DescribeTable now exits with an error if it is not passed any Entries [a4c9865]</li>
</ul>
<h2>Fixes</h2>
<ul>
<li>fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency [92c88d5]</li>
<li>Make the outline command able to use the DSL import [1be2427]</li>
</ul>
<h2>Maintenance</h2>
<ul>
<li>chore(docs): delete no meaning d [57c373c]</li>
<li>chore(docs): Fix hyperlinks [30526d5]</li>
<li>chore(docs): fix code blocks without language settings [cf611c4]</li>
<li>fix intra-doc link [b541bcb]</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md">github.com/onsi/ginkgo/v2's changelog</a>.</em></p>
<blockquote>
<h2>2.3.1</h2>
<h2>Fixes</h2>
<p>Several users were invoking <code>ginkgo</code> by installing the latest version of the cli via <code>go install github.com/onsi/ginkgo/v2/ginkgo@latest</code>. When 2.3.0 was released this resulted in an influx of issues as CI systems failed due to a change in the internal contract between the Ginkgo CLI and the Ginkgo library. Ginkgo only supports running the same version of the library as the cli (which is why both are packaged in the same repository).</p>
<p>With this patch release, the ginkgo CLI can now identify a version mismatch and emit a helpful error message.</p>
<ul>
<li>Ginkgo cli can identify version mismatches and emit a helpful error message [bc4ae2f]</li>
<li>further emphasize that a version match is required when running Ginkgo on CI and/or locally [2691dd8]</li>
</ul>
<h2>Maintenance</h2>
<ul>
<li>bump gomega to v1.22.0 [822a937]</li>
</ul>
<h2>2.3.0</h2>
<h3>Interruptible Nodes and Timeouts</h3>
<p>Ginkgo now supports per-node and per-spec timeouts on interruptible nodes. Check out the <a href="https://onsi.github.io/ginkgo/#spec-timeouts-and-interruptible-nodes">documentation for all the details</a> but the gist is you can now write specs like this:</p>
<pre lang="go"><code>It("is interruptible", func(ctx SpecContext) { // or context.Context instead of SpecContext, both are valid.
// do things until `ctx.Done()` is closed, for example:
req, err := http.NewRequestWithContext(ctx, "POST", "/build-widgets", nil)
Expect(err).NotTo(HaveOccured())
_, err := http.DefaultClient.Do(req)
Expect(err).NotTo(HaveOccured())
<pre><code>Eventually(client.WidgetCount).WithContext(ctx).Should(Equal(17))
</code></pre>
<p>}, NodeTimeout(time.Second<em>20), GracePeriod(5</em>time.Second))
</code></pre></p>
<p>and have Ginkgo ensure that the node completes before the timeout elapses. If it does elapse, or if an external interrupt is received (e.g. <code>^C</code>) then Ginkgo will cancel the context and wait for the Grace Period for the node to exit before proceeding with any cleanup nodes associated with the spec. The <code>ctx</code> provided by Ginkgo can also be passed down to Gomega's <code>Eventually</code> to have all assertions within the node governed by a single deadline.</p>
<h3>Features</h3>
<ul>
<li>Ginkgo now records any additional failures that occur during the cleanup of a failed spec. In prior versions this information was quietly discarded, but the introduction of a more rigorous approach to timeouts and interruptions allows Ginkgo to better track subsequent failures.</li>
<li><code>SpecContext</code> also provides a mechanism for third-party libraries to provide additional information when a Progress Report is generated. Gomega uses this to provide the current state of an <code>Eventually().WithContext()</code> assertion when a Progress Report is requested.</li>
<li>DescribeTable now exits with an error if it is not passed any Entries [a4c9865]</li>
</ul>
<h2>Fixes</h2>
<ul>
<li>fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency [92c88d5]</li>
<li>Make the outline command able to use the DSL import [1be2427]</li>
</ul>
<h2>Maintenance</h2>
<ul>
<li>chore(docs): delete no meaning d [57c373c]</li>
<li>chore(docs): Fix hyperlinks [30526d5]</li>
<li>chore(docs): fix code blocks without language settings [cf611c4]</li>
<li>fix intra-doc link [b541bcb]</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/onsi/ginkgo/commit/2cc2219b4ec8630df2ee1b112237b4ae56da1a75"><code>2cc2219</code></a> v2.3.1</li>
<li><a href="https://github.com/onsi/ginkgo/commit/bc4ae2f8c2ed825d839daf7162791fe28977e483"><code>bc4ae2f</code></a> Ginkgo cli can identify version mismatches and emit a helpful error message</li>
<li><a href="https://github.com/onsi/ginkgo/commit/2691dd8eacf8bdce03fc40c42434fac1fa60a282"><code>2691dd8</code></a> further emphasize that a version match is required when running Ginkgo on CI ...</li>
<li><a href="https://github.com/onsi/ginkgo/commit/822a937ec32e0b3751c474c815c7dce97396d75b"><code>822a937</code></a> bump gomega to v1.22.0</li>
<li><a href="https://github.com/onsi/ginkgo/commit/87fc2ec66867a62b6b7da2f372c600278b103283"><code>87fc2ec</code></a> v2.3.0</li>
<li><a href="https://github.com/onsi/ginkgo/commit/bda6ffe4a1ab18b0b59007b063cae6f97949ea5e"><code>bda6ffe</code></a> clarify what we mean by cleanup nodes</li>
<li><a href="https://github.com/onsi/ginkgo/commit/b182b1f18fde956f4477dc7d6860ba4b4ba5b4bc"><code>b182b1f</code></a> document how SpecContext and Eventually work together</li>
<li><a href="https://github.com/onsi/ginkgo/commit/5ddc567d4d32bdf2fc762dc548bc15fb79616022"><code>5ddc567</code></a> be more consistent about 'Timedout' vs 'Timeout'</li>
<li><a href="https://github.com/onsi/ginkgo/commit/a87ec827fd11f8e52f1a9e91d7247a22440b6a91"><code>a87ec82</code></a> Gingko now records additional failures that occur during cleanup of a failed ...</li>
<li><a href="https://github.com/onsi/ginkgo/commit/cd395fc9061f7549f2511c27a319f674d307e94b"><code>cd395fc</code></a> ensure post-timeout failure makes it into the JUnit report</li>
<li>Additional commits viewable in <a href="https://github.com/onsi/ginkgo/compare/v2.2.0...v2.3.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] closed pull request #1389: chore(deps): bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.1 in /test/e2e
Posted by GitBox <gi...@apache.org>.
dependabot[bot] closed pull request #1389: chore(deps): bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.1 in /test/e2e
URL: https://github.com/apache/apisix-ingress-controller/pull/1389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dependabot[bot] commented on pull request #1389: chore(deps): bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.1 in /test/e2e
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on PR #1389:
URL: https://github.com/apache/apisix-ingress-controller/pull/1389#issuecomment-1288343990
Superseded by #1400.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org