[jira] [Commented] (AMQ-6034) The StompConnection class contains incorrect STOMP code

["Timothy Bish (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990477#comment-14990477 ] 

Timothy Bish commented on AMQ-6034:
-----------------------------------

StompConnection is primarily a testing tool and its only use in the ActiveMQ project is in the STOMP unit tests.  We welcome contributions though so if you have use for it and find that it has problems we'd be glad to accept patches for it.

> The StompConnection class contains incorrect STOMP code
> -------------------------------------------------------
>
>                 Key: AMQ-6034
>                 URL: https://issues.apache.org/jira/browse/AMQ-6034
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: stomp
>            Reporter: Lionel Cons
>
> The org.apache.activemq.transport.stomp.StompConnection class contains  incorrect code related to STOMP frame handling.
> On the receiving side, receive() uses StompWireFormat which is correct. However, the class also contains receiveFrame() which is not correct.
> On the sending side, most related methods use the StompFrame.format() method which is not correct, StompWireFormat.marshal() should be used instead.
> So, StompWireFormat should be used in all the marshal/unmarshal operations and equivalent code should be removed from the related classes like StompConnection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)