You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Tom-Newton (via GitHub)" <gi...@apache.org> on 2024/02/18 22:58:54 UTC
[PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Tom-Newton opened a new pull request, #40120:
URL: https://github.com/apache/arrow/pull/40120
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
`cffi` 1.16.0 conda release for python 3.9 was modified 12 days ago and it seems to have broken `grpcio==1.59.0`.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Restrict `cffi` to < 1.16.0.
### Are these changes tested?
No new functionality to test. Should fix existing CI failures.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "Tom-Newton (via GitHub)" <gi...@apache.org>.
Tom-Newton commented on PR #40120:
URL: https://github.com/apache/arrow/pull/40120#issuecomment-1952630269
Better fix was merged https://github.com/apache/arrow/pull/40131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #40120:
URL: https://github.com/apache/arrow/pull/40120#discussion_r1493908196
##########
ci/conda_env_python.txt:
##########
@@ -17,7 +17,7 @@
# don't add pandas here, because it is not a mandatory test dependency
boto3 # not a direct dependency of s3fs, but needed for our s3fs fixture
-cffi
+cffi<1.16.0 # cffi 1.16.0 with Python 3.9 has an incompatibility with grpcio (required for GCS testbench)
Review Comment:
Good catch!
Can we restrict this pin only for Python 3.9? It seems that we can do it with `requirements.txt` but I don't know whether we can do it with conda...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "Tom-Newton (via GitHub)" <gi...@apache.org>.
Tom-Newton commented on code in PR #40120:
URL: https://github.com/apache/arrow/pull/40120#discussion_r1493925298
##########
ci/conda_env_python.txt:
##########
@@ -17,7 +17,7 @@
# don't add pandas here, because it is not a mandatory test dependency
boto3 # not a direct dependency of s3fs, but needed for our s3fs fixture
-cffi
+cffi<1.16.0 # cffi 1.16.0 with Python 3.9 has an incompatibility with grpcio (required for GCS testbench)
Review Comment:
I don't know if it's possible with conda. The only docs I could find about the version specification syntax was this https://docs.conda.io/projects/conda/en/4.6.0/_downloads/52a95608c49671267e40c689e0bc00ca/conda-cheatsheet.pdf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "Tom-Newton (via GitHub)" <gi...@apache.org>.
Tom-Newton closed pull request #40120: GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9
URL: https://github.com/apache/arrow/pull/40120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40120:
URL: https://github.com/apache/arrow/pull/40120#issuecomment-1951474629
:warning: GitHub issue #40112 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40112: [CI][Packaging][Conda] Fix installing GCS testbench on python 3.9 [arrow]
Posted by "xhochy (via GitHub)" <gi...@apache.org>.
xhochy commented on PR #40120:
URL: https://github.com/apache/arrow/pull/40120#issuecomment-1951746618
We can fix that on the conda-forge side so that you don't have to restrict anything here. Do you have an upstream bug report I could reference to argue for retroactively adding the pin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org