You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by David Green <da...@maketechnologies.com> on 2002/08/07 03:50:27 UTC

defect fix to httpclient

It appears as if cookie headers are loosing a ',' character after being
parsed.  The following code change fixes the defect (patch against version
1.10 of HeaderElement.java).

David Green
CTO
Make Technologies, Inc.
604-738-4999 ext. 111


--- HeaderElement.java.orig     Tue Aug  6 18:40:16 2002
+++ HeaderElement.java  Tue Aug  6 17:55:06 2002
@@ -305,7 +305,7 @@
                         nextToken.endsWith("Saturday") ||
                         nextToken.endsWith("Sunday" )) {

-                        nextToken += tokenizer.nextToken(",");
+                        nextToken += "," + tokenizer.nextToken(",");
                     }
                 }
             } catch (NoSuchElementException exception) {


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: defect fix to httpclient

Posted by Jeff Dever <js...@sympatico.ca>.
Hey David,

I applied your patch.  I'll be looking forward to implementing regular
expression parsing to make all these little fragilities goaway.  Probably will
not get to it untill winter though :-(

604?  That sounds like a Vancouver number.  I grew up in Victoria myslef, and am
currently living in Ottawa.


David Green wrote:

> It appears as if cookie headers are loosing a ',' character after being
> parsed.  The following code change fixes the defect (patch against version
> 1.10 of HeaderElement.java).
>
> David Green
> CTO
> Make Technologies, Inc.
> 604-738-4999 ext. 111
>
> --- HeaderElement.java.orig     Tue Aug  6 18:40:16 2002
> +++ HeaderElement.java  Tue Aug  6 17:55:06 2002
> @@ -305,7 +305,7 @@
>                          nextToken.endsWith("Saturday") ||
>                          nextToken.endsWith("Sunday" )) {
>
> -                        nextToken += tokenizer.nextToken(",");
> +                        nextToken += "," + tokenizer.nextToken(",");
>                      }
>                  }
>              } catch (NoSuchElementException exception) {
>
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>