[jira] [Commented] (GEODE-4605) Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354444#comment-16354444 ] 

ASF subversion and git services commented on GEODE-4605:
--------------------------------------------------------

Commit f4f4c7b34d194d5d4d68aad34cc2d6c95b3721c1 in geode-native's branch refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f4f4c7b ]

GEODE-4605: Keep domain object via shared_ptr<void>. (#205)

- Removes UserDeallocator function.

> Replace void* with std::shared_ptr<void> in PdxSerializer/PdxWrapper
> --------------------------------------------------------------------
>
>                 Key: GEODE-4605
>                 URL: https://issues.apache.org/jira/browse/GEODE-4605
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Assignee: Jacob S. Barrett
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> With {{void*}} it is necessary to keep a deleter function around to free memory allocated to the type erased pointer. Switching to \{{std::shared_ptr<void>}} keeps the type erased pointer but preserves the correct delete behavior with the added bonus of non-ambiguous pointer ownership.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)