You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Kenney Westerhof (JIRA)" <ji...@codehaus.org> on 2005/07/11 11:05:18 UTC

[jira] Created: (MNG-567) Possible error in PluginParameterExpressionEvaluator

Possible error in PluginParameterExpressionEvaluator
----------------------------------------------------

         Key: MNG-567
         URL: http://jira.codehaus.org/browse/MNG-567
     Project: Maven 2
        Type: Bug
  Components: maven-core  
 Reporter: Kenney Westerhof


        else if ( expression.startsWith( "project" ) )
        {
            try
            {
         
                int pathSeparator = expression.indexOf( "/" );

                if ( pathSeparator > 0 )
                {
                    String pathExpression = expression.substring( 1, pathSeparator );

seems wrong to me: say expression = "project.FOO/BAR";

then pathExpression will be "roject.FOO".

Also, there is a lot of need for the ExpressionEvaluator functionality in plugins (to access the
project.* variables at runtime, not at configuration time). Any chance this evaluator can be made into
a component? (the problem is that the constructor takes arguments that are also not available
in a a plugin.)


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-567) Possible error in PluginParameterExpressionEvaluator

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-567?page=all ]
     
Brett Porter closed MNG-567:
----------------------------

    Resolution: Fixed

fixed. luckily the expression evaluator ignores everything up to ".", so project is as valid as pom and as roject.

For your other idea - please put together a proposal and use case. I think 2.1 is the time for that though.

> Possible error in PluginParameterExpressionEvaluator
> ----------------------------------------------------
>
>          Key: MNG-567
>          URL: http://jira.codehaus.org/browse/MNG-567
>      Project: Maven 2
>         Type: Bug
>   Components: maven-core
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-1

>
>
>         else if ( expression.startsWith( "project" ) )
>         {
>             try
>             {
>          
>                 int pathSeparator = expression.indexOf( "/" );
>                 if ( pathSeparator > 0 )
>                 {
>                     String pathExpression = expression.substring( 1, pathSeparator );
> seems wrong to me: say expression = "project.FOO/BAR";
> then pathExpression will be "roject.FOO".
> Also, there is a lot of need for the ExpressionEvaluator functionality in plugins (to access the
> project.* variables at runtime, not at configuration time). Any chance this evaluator can be made into
> a component? (the problem is that the constructor takes arguments that are also not available
> in a a plugin.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-567) Possible error in PluginParameterExpressionEvaluator

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-567?page=all ]

Brett Porter updated MNG-567:
-----------------------------

    Fix Version: 2.0-beta-1

> Possible error in PluginParameterExpressionEvaluator
> ----------------------------------------------------
>
>          Key: MNG-567
>          URL: http://jira.codehaus.org/browse/MNG-567
>      Project: Maven 2
>         Type: Bug
>   Components: maven-core
>     Reporter: Kenney Westerhof
>      Fix For: 2.0-beta-1

>
>
>         else if ( expression.startsWith( "project" ) )
>         {
>             try
>             {
>          
>                 int pathSeparator = expression.indexOf( "/" );
>                 if ( pathSeparator > 0 )
>                 {
>                     String pathExpression = expression.substring( 1, pathSeparator );
> seems wrong to me: say expression = "project.FOO/BAR";
> then pathExpression will be "roject.FOO".
> Also, there is a lot of need for the ExpressionEvaluator functionality in plugins (to access the
> project.* variables at runtime, not at configuration time). Any chance this evaluator can be made into
> a component? (the problem is that the constructor takes arguments that are also not available
> in a a plugin.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org