You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/04 10:49:21 UTC

[GitHub] [cordova-plugin-file] JiaLiPassion opened a new pull request #215: fix: invoke onEvent listener with _realReader as applyThis

JiaLiPassion opened a new pull request #215: fix: invoke onEvent listener with _realReader as applyThis
URL: https://github.com/apache/cordova-plugin-file/pull/215
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android,ios,Browser
   ### What does this PR do?
   FileReader.onEvent such as FileReader.onload should call with `this._realReader`
   
   ### What testing has been done on this change?
   Test with ios Application.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   
   
   Fix CB-13179, FileReader should invoke onEvent listener with this._realReader as applyThis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org