You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/15 12:50:00 UTC
[jira] [Commented] (WW-5191) template/simple/textarea.ftl not rendering parameters correctly
[ https://issues.apache.org/jira/browse/WW-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554565#comment-17554565 ]
ASF subversion and git services commented on WW-5191:
-----------------------------------------------------
Commit 75ea7709e7bb074cfebaeec81500e100d47405ce in struts's branch refs/heads/WW-5191-textarea-max-length from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=75ea7709e ]
WW-5191 Fixes placement of maxLength and minLength attributes in <s:textarea/> tag
> template/simple/textarea.ftl not rendering parameters correctly
> ---------------------------------------------------------------
>
> Key: WW-5191
> URL: https://issues.apache.org/jira/browse/WW-5191
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Affects Versions: 6.0.0
> Reporter: Burton Rhodes
> Priority: Major
> Fix For: 6.0.1
>
>
> The "simple" textarea.ftl (I haven't checked the other templates) does not have the ending ">" in the correct location. As a result, maxlength and minlength are displayed within the textarea editor.
>
> *Current*
> {code:java}
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" />
> ><#rt/> <#-- !! WRONG LOCATION !! -->
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> </textarea> {code}
>
> *Should be*
> {code:java}
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" />
> <#include "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" />
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> ><#rt/> <#-- !! CORRECT LOCATION !! -->
> </textarea>{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)