You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "namelessssssssssss (via GitHub)" <gi...@apache.org> on 2024/05/20 06:42:07 UTC
[PR] New metadata service [dubbo]
namelessssssssssss opened a new pull request, #14210:
URL: https://github.com/apache/dubbo/pull/14210
## Purpose of the Change
This PR introduces a new version of `MetadataService` (V2) based on Protobuf, which provides better compatibility with Dubbo-go.
## Brief Changelog
To use `MetadataServiceV2`, the application must meet the following requirements:
* The application has imported Protobuf dependencies.
* `metadataServiceProtocol` is configured as 'tri', or at least one service is using the triple protocol.
Currently, `MetadataServiceV2` will automatically export along with `MetadataService` (V1, on the same port) if the above requirements are **satisfied**. If `onlyUseMetadataV2` is set to `true`, only `MetadataServiceV2` will be exported. If the above requirements are **not satisfied**, Dubbo will still only export `MetadataService` (V1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2144223808
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2141461020
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on code in PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#discussion_r1650060772
##########
dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto:
##########
@@ -0,0 +1,30 @@
+syntax = "proto3";
Review Comment:
License header is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2132167699
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2143426961
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2159900607
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "namelessssssssssss (via GitHub)" <gi...@apache.org>.
namelessssssssssss commented on code in PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#discussion_r1650069182
##########
dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto:
##########
@@ -0,0 +1,30 @@
+syntax = "proto3";
Review Comment:
OK. License are added now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2127248056
Well done. Generally looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2139133038
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#issuecomment-2184991700
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210) **Quality Gate passed**
Issues
 [143 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14210&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14210&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_coverage&view=list)
 [18.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14210&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14210)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] New metadata service [dubbo]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #14210:
URL: https://github.com/apache/dubbo/pull/14210#discussion_r1644025989
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataUtils.java:
##########
@@ -96,6 +96,8 @@ public class ServiceInstanceMetadataUtils {
*/
public static final String METADATA_STORAGE_TYPE_PROPERTY_NAME = "dubbo.metadata.storage-type";
+ public static final String METADATA_SERVICE_VERSION_NAME = "dubbo.metadata.service-version";
Review Comment:
Use as short a name as possible, for example, `meta-v`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org