[GitHub] [cordova-plugin-screen-orientation] erisu commented on a change in pull request #51: Convert jshint to eslint

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #51: Convert jshint to eslint
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/51#discussion_r398625734
 
 

 ##########
 File path: tests/tests.js
 ##########
 @@ -139,23 +137,23 @@ exports.defineAutoTests = function() {
         });
     });
 };
-exports.defineManualTests = function(contentEl, createActionButton) {
+exports.defineManualTests = function (contentEl, createActionButton) {
 
-    createActionButton('Listen to orientationchange events', function() {
-        window.addEventListener("orientationchange", function(){
-            contentEl.innerHTML += '<p>Orientation changed! ' + screen.orientation.type + '</p>';
+    createActionButton('Listen to orientationchange events', function () {
+        window.addEventListener('orientationchange', function () {
+            contentEl.innerHTML += '<p>Orientation changed! ' + window.screen.orientation.type + '</p>';
 
 Review comment:
   +1 for adding `window.` to resolve the eslint issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org