[GitHub] [commons-lang] kinow commented on pull request #907: Increase test coverage of functional interfaces

[GitBox <gi...@apache.org>]

kinow commented on PR #907:
URL: https://github.com/apache/commons-lang/pull/907#issuecomment-1148545799

   >There is repetition, but because there isn't a common interface for each nop, and each instance requires different parameter types in the apply call I can't see a good way of using a ParameterisedTest, e.g.
   
   Good point. Just checked out the branch and also couldn't come up with parameterised tests.
   
   >I could move the tests inside of FailableFunctionsTest either individually or bunched (similar to other tests in the class), e.g.
   
   Hmmm, I **think** this option might be simpler as we have already the other methods being tested in the same class. Otherwise the individual test classes are testing only the `nop` method.
   
   But we can leave the PR as-is and wait others to review if you'd like. For me either way is fine.
   
   Thanks!
   -Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org