You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@steitz.com> on 2003/09/14 00:31:49 UTC
[collections] Running the tests
Currently neither the ant nor maven [collection] builds runs the
subpackage tests. Janek Bogucki just submitted a patch
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
entry point to the ant test target from TestAll (just the top level) to
TestAllPackages. I have locally modified project.xml to include
**/TestAll.java. I would like to commit these changes. Any objections?
Also, why not dispense with the ant entry point (and TestAllPackages)
and just use **/TestAll.java to select tests? What am I missing here?
Phil
Re: [collections] Running the tests
Posted by Stephen Colebourne <sc...@btopenworld.com>.
This confusion arises from a change I made to add the TestAllPackages class.
I wanted a way to run the tests from Eclipse without using Ant. Hence
TestAllPackages.
Clearly I failed to finish the job and update the Ant/Maven scripts.... :-(
Stephen
----- Original Message -----
From: "Phil Steitz" <ph...@steitz.com>
> Henri Yandell wrote:
> > As long as 'ant test' and 'maven jar' run all the unit tests [rather
than
> > any performance tests] I don't mind what's going on.
> >
> > I'm -1 to 'ant test'/'maven jar' not running all the tests, and hadn't
> > realised it wasn't running them all.
>
> Janek's patch (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155)
> will fix the ant build to run all tests using TestAllPackages as the
> entry point. The corresponding change should be made for maven (using
> TestAllPackages, non **/TestAll.java). I will do this if there are no
> objections.
>
> >
> > Hen
> >
> > On Mon, 15 Sep 2003, Rodney Waldhoff wrote:
> >
> >
> >>I'm think -1 to forcing the user to use "**/TestAll.java" to
> >>select the unit test suite to execute. What's the harm in giving the
user
> >>a way to execute the full test suite without using Ant/Maven or an IDE
to
> >>inspect the filesystem for Test classes?
> >>
> >>On Sat, 13 Sep 2003, Phil Steitz wrote:
> >>
> >>
> >>>Currently neither the ant nor maven [collection] builds runs the
> >>>subpackage tests. Janek Bogucki just submitted a patch
> >>>(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
> >>>entry point to the ant test target from TestAll (just the top level) to
> >>>TestAllPackages. I have locally modified project.xml to include
> >>>**/TestAll.java. I would like to commit these changes. Any
objections?
> >>>
> >>>Also, why not dispense with the ant entry point (and TestAllPackages)
> >>>and just use **/TestAll.java to select tests? What am I missing here?
> >>>
> >>>Phil
> >>>
> >>
> >>--
> >>- Rod <http://radio.weblogs.com/0122027/>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [collections] Running the tests
Posted by Stephen Colebourne <sc...@btopenworld.com>.
This confusion arises from a change I made to add the TestAllPackages class.
I wanted a way to run the tests from Eclipse without using Ant. Hence
TestAllPackages.
Clearly I failed to finish the job and update the Ant/Maven scripts.... :-(
Stephen
----- Original Message -----
From: "Phil Steitz" <ph...@steitz.com>
> Henri Yandell wrote:
> > As long as 'ant test' and 'maven jar' run all the unit tests [rather
than
> > any performance tests] I don't mind what's going on.
> >
> > I'm -1 to 'ant test'/'maven jar' not running all the tests, and hadn't
> > realised it wasn't running them all.
>
> Janek's patch (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155)
> will fix the ant build to run all tests using TestAllPackages as the
> entry point. The corresponding change should be made for maven (using
> TestAllPackages, non **/TestAll.java). I will do this if there are no
> objections.
>
> >
> > Hen
> >
> > On Mon, 15 Sep 2003, Rodney Waldhoff wrote:
> >
> >
> >>I'm think -1 to forcing the user to use "**/TestAll.java" to
> >>select the unit test suite to execute. What's the harm in giving the
user
> >>a way to execute the full test suite without using Ant/Maven or an IDE
to
> >>inspect the filesystem for Test classes?
> >>
> >>On Sat, 13 Sep 2003, Phil Steitz wrote:
> >>
> >>
> >>>Currently neither the ant nor maven [collection] builds runs the
> >>>subpackage tests. Janek Bogucki just submitted a patch
> >>>(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
> >>>entry point to the ant test target from TestAll (just the top level) to
> >>>TestAllPackages. I have locally modified project.xml to include
> >>>**/TestAll.java. I would like to commit these changes. Any
objections?
> >>>
> >>>Also, why not dispense with the ant entry point (and TestAllPackages)
> >>>and just use **/TestAll.java to select tests? What am I missing here?
> >>>
> >>>Phil
> >>>
> >>
> >>--
> >>- Rod <http://radio.weblogs.com/0122027/>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
Re: [collections] Running the tests
Posted by Phil Steitz <ph...@steitz.com>.
Henri Yandell wrote:
> As long as 'ant test' and 'maven jar' run all the unit tests [rather than
> any performance tests] I don't mind what's going on.
>
> I'm -1 to 'ant test'/'maven jar' not running all the tests, and hadn't
> realised it wasn't running them all.
Janek's patch (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155)
will fix the ant build to run all tests using TestAllPackages as the
entry point. The corresponding change should be made for maven (using
TestAllPackages, non **/TestAll.java). I will do this if there are no
objections.
>
> Hen
>
> On Mon, 15 Sep 2003, Rodney Waldhoff wrote:
>
>
>>I'm think -1 to forcing the user to use "**/TestAll.java" to
>>select the unit test suite to execute. What's the harm in giving the user
>>a way to execute the full test suite without using Ant/Maven or an IDE to
>>inspect the filesystem for Test classes?
>>
>>On Sat, 13 Sep 2003, Phil Steitz wrote:
>>
>>
>>>Currently neither the ant nor maven [collection] builds runs the
>>>subpackage tests. Janek Bogucki just submitted a patch
>>>(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
>>>entry point to the ant test target from TestAll (just the top level) to
>>>TestAllPackages. I have locally modified project.xml to include
>>>**/TestAll.java. I would like to commit these changes. Any objections?
>>>
>>>Also, why not dispense with the ant entry point (and TestAllPackages)
>>>and just use **/TestAll.java to select tests? What am I missing here?
>>>
>>>Phil
>>>
>>
>>--
>>- Rod <http://radio.weblogs.com/0122027/>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
Re: [collections] Running the tests
Posted by Henri Yandell <ba...@generationjava.com>.
As long as 'ant test' and 'maven jar' run all the unit tests [rather than
any performance tests] I don't mind what's going on.
I'm -1 to 'ant test'/'maven jar' not running all the tests, and hadn't
realised it wasn't running them all.
Hen
On Mon, 15 Sep 2003, Rodney Waldhoff wrote:
> I'm think -1 to forcing the user to use "**/TestAll.java" to
> select the unit test suite to execute. What's the harm in giving the user
> a way to execute the full test suite without using Ant/Maven or an IDE to
> inspect the filesystem for Test classes?
>
> On Sat, 13 Sep 2003, Phil Steitz wrote:
>
> > Currently neither the ant nor maven [collection] builds runs the
> > subpackage tests. Janek Bogucki just submitted a patch
> > (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
> > entry point to the ant test target from TestAll (just the top level) to
> > TestAllPackages. I have locally modified project.xml to include
> > **/TestAll.java. I would like to commit these changes. Any objections?
> >
> > Also, why not dispense with the ant entry point (and TestAllPackages)
> > and just use **/TestAll.java to select tests? What am I missing here?
> >
> > Phil
> >
>
> --
> - Rod <http://radio.weblogs.com/0122027/>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
Re: [collections] Running the tests
Posted by Rodney Waldhoff <rw...@apache.org>.
I'm think -1 to forcing the user to use "**/TestAll.java" to
select the unit test suite to execute. What's the harm in giving the user
a way to execute the full test suite without using Ant/Maven or an IDE to
inspect the filesystem for Test classes?
On Sat, 13 Sep 2003, Phil Steitz wrote:
> Currently neither the ant nor maven [collection] builds runs the
> subpackage tests. Janek Bogucki just submitted a patch
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
> entry point to the ant test target from TestAll (just the top level) to
> TestAllPackages. I have locally modified project.xml to include
> **/TestAll.java. I would like to commit these changes. Any objections?
>
> Also, why not dispense with the ant entry point (and TestAllPackages)
> and just use **/TestAll.java to select tests? What am I missing here?
>
> Phil
>
--
- Rod <http://radio.weblogs.com/0122027/>
Re: [collections] Running the tests
Posted by Phil Steitz <ph...@steitz.com>.
Phil Steitz wrote:
> Currently neither the ant nor maven [collection] builds runs the
> subpackage tests. Janek Bogucki just submitted a patch
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23155) to change the
> entry point to the ant test target from TestAll (just the top level) to
> TestAllPackages. I have locally modified project.xml to include
> **/TestAll.java. I would like to commit these changes. Any objections?
>
> Also, why not dispense with the ant entry point (and TestAllPackages)
> and just use **/TestAll.java to select tests? What am I missing here?
Doh! Many repeated tests. I will change both to TestAllPackages unless
I hear complaints....
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>